mnin / coinbase-moneymoney

Fetches balances from Coinbase API and returns them as securities
MIT License
24 stars 4 forks source link

Ethereum not in securities list #6

Closed MarkusBRLN closed 3 years ago

MarkusBRLN commented 3 years ago

I recently (a week ago) added Ethereum to my coinbase account. Since then it is not shown Money Money.

Just updated to the recent version of the extension, the error persists. I am using MoneyMoney version 2.4.3 (384) Beta

Any ideas what's wrong?

alemuenchen commented 3 years ago

It happened also to me. I resolved it by canceling the Money Money extension and redoing the process from the beginning, that is: creating a new API-Key on Coinbase and choosing add all wallets.

mnin commented 3 years ago

How are the permissions set at Coinbase?

Are they like the screenshot here?

Screenshot 2021-03-26 at 10 22 18

Can you share from the MoneyMoney log the API calls (please pay attention and anonymize the numbers)?

alemuenchen commented 3 years ago

Yes, so it is right. I don't share.

mnin commented 3 years ago

@MarkusBRLN were you able to adjust or recreate the API key? Did that help?

MarkusBRLN commented 3 years ago

@mnin the API key has the correct permissions. All accounts are included and all permissions are given.

Where do I find the log file you mentioned in your first answer?

mnin commented 3 years ago

@MarkusBRLN

Mark then there the appropriate entries, after you have updated only the account Coinbase and send me these best, there are no credentials in it.

Contact me via Twitter @mnin

MarkusBRLN commented 3 years ago

Pulled the log, XXXXed out the amounts. Hope it helps.

210323_MoneyMoney_Log_Coinbase.pdf

mnin commented 3 years ago

@MarkusBRLN I don't support PDF per se, couldn't this just be a JSON file?

I can't see any Ethereum account balance in the PDF unfortunately, how is the API key configured?

MarkusBRLN commented 3 years ago

@mnin the API key has access to all accounts/currencies and also all permissions are given.

Screenshot 2021-03-31 at 10 36 56 Screenshot 2021-03-31 at 10 36 51

mnin commented 3 years ago

@MarkusBRLN the API key for MoneyMoney should not have any rights to change things, see my screenshot above.

Are you using a vault for Ethereum?

MarkusBRLN commented 3 years ago

@mnin Thanks for the hint, I have adjust my API Key permissions.

I am not using a Vault for Ethereum.

mnin commented 3 years ago

I looked at the Coinbase website for a while, unfortunately it doesn't really describe why the /accounts call doesn't just return all accounts. Then I saw the trick they do themselves on their website: limit=100.

I posted the bug fix in the src/ directory and will push this new version signed soon.

If you want, you can try it with the beta version of MoneyMoney.

mnin commented 3 years ago

@MarkusBRLN the signed version is updated, feel free to try it out https://github.com/mnin/coinbase-moneymoney/blob/master/dist/Coinbase.lua

MarkusBRLN commented 3 years ago

works like a charm. Thanks for looking into it and fixing!