search

mnlcpc / Unsplash-It-Sketch

A plugin to quickly include great looking image from Unsplash.com in your Sketch projects.
421 stars 23 forks source link

Deprecation warning #17

Closed bomberstudios closed 7 years ago

bomberstudios commented 8 years ago

Hi there,

As you probably know, setPatternImage: has been deprecated for a while, and it will be removed in Sketch v40. Please update your Plugin to use setImage: instead or it won't work in the next release :)

fhuel commented 8 years ago

Thank you so much for letting me know Ale,

really really appreciate that!

romiem commented 8 years ago

When will this plugin be updated? I use Unsplash It almost daily! (v40.0 of Sketch is already out and this plugin is now broken)

BrianSipple commented 8 years ago

I can confirm alongside @romiem that this plugin is now broken in Sketch v40. @bomberstudios, for those browsing the list of issues, it might be helpful to rename this one to reflect that.

alexdoronin commented 8 years ago

To fix it:
~/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Unsplash It Sketch/Unsplash It.sketchplugin/Contents/Sketch/unsplashit.cocoascript

Instead of: fill.setImage( imageData );

This line: fill.setImage(MSImageData.alloc().initWithImage_convertColorSpace(imageData, false))

It works in v40.

fhuel commented 7 years ago

hey everyone, finally working fine now. Sorry guys if it took me this long :P