search

mnlcpc / Unsplash-It-Sketch

A plugin to quickly include great looking image from Unsplash.com in your Sketch projects.
421 stars 23 forks source link

constant crashing #5

Closed nikiniki9doors closed 7 years ago

nikiniki9doors commented 8 years ago

Cannot get this plugin to work - every time it crashes sketch.

fhuel commented 8 years ago

Hey, thank you for letting me know. Could you please let me know the version of both Sketch and OsX ?

MarttiR commented 8 years ago

The plugin was working excellently for some time (Sketch 3.4.4-17249 & El Capitan), but suddenly started to crash Sketch on every activation. The problem seems to happen on line 47:

var imageData = NSImage.alloc().initWithData( get(imageURL) );

There doesn't seem to be any logic validating whether the HTTP response is OK before it's passed to initWithData(). I'm not in any way familiar with the environment, but perhaps the API doesn't like too many requests and is returning an error?

fhuel commented 8 years ago

Thank you @MarttiR , I think you hit the point Working on that Thanks!

ckuchibh commented 8 years ago

When is the fix expected?

howardstein commented 8 years ago

Installed it on Sketch 40. Made a series of rectangles — (I'm a beginner w/Sketch), ran the plugin and it turned one grey rectangle white. Whether selecting one shape or several, am not getting any images loading into the selected shape. Suggestions? Thanks.

fhuel commented 7 years ago

there was an in incompatibility bug with Sketch 4. Solved now, the plugin should run smoothly now

ckuchibh commented 7 years ago

Thank you!

Best, Chandra Kuchibhotla

DISCLAIMER: The information contained in this message (including attached documents) may be privileged, confidential, and protected from disclosure. If you are not the intended recipient, or an employee, or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting from your computer. Opinions, conclusions, and other information in this message that do not relate to official CKLABS business are those of the sender and are neither given nor endorsed by CKLABS.

On Monday, 10 October 2016 at 2:20 AM, Manuele Capacci wrote:

there was an in incompatibility bug with Sketch 4. Solved now, the plugin should run smoothly now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub (https://github.com/fhuel/Unsplash-It-Sketch/issues/5#issuecomment-252511799), or mute the thread (https://github.com/notifications/unsubscribe-auth/ADbzQrBZUi_f2GvFfZW6cVL8gSjyo5ekks5qyVOMgaJpZM4GobPH).

sureshmurali commented 7 years ago

Sketch 43.1 OS X 10.12.4 Crashes sketch application :(