search

mnoorenberghe / webtrees-facebook

Facebook integration for webtrees genealogy software
https://mnoorenberghe.github.io/webtrees-facebook/
GNU General Public License v2.0
13 stars 5 forks source link

Updates to support webtrees 1.7.x #22

Closed Ephemerality closed 7 years ago

Ephemerality commented 7 years ago

Initial changes required to run the module on webtrees 1.7.x (tested in 1.7.9). It may belong on a different branch while testing continues and could definitely use some review, but it seems to do the trick for now :)
Zend framework was removed, so the translations code had to be removed. I read somewhere that simply having translations in the /language folder will get automatically loaded and used by the I18n class, but did not test it.

mnoorenberghe commented 7 years ago

Sorry for the delay and thanks very much for the patch. I will hopefully have time to look at this next weekend as I'm very busy with work at the moment.

mnoorenberghe commented 7 years ago

It would be much easier to review if separate commits were used for each class of change. e.g. one commit switching WT_Filter to Filter, another for style changes related to spaces around periods, etc.

Ephemerality commented 7 years ago

Sorry about that. I picked away at it piece by piece without really thinking about it. I could redo it if you want, for the sake of readability.