mnordseth / enet-homeassistant

Enet Smart Home integration for Home Assistant
Apache License 2.0
26 stars 7 forks source link

Support for multiple input- and output-functions per channel #27

Closed ChrisSoelder closed 2 months ago

ChrisSoelder commented 2 months ago

Hi Magnus!

I just finished some upgrades and refactorings to your great work to make it possible to call and hold the state for more than one pair of input/outfunctions per channel.

This enables me in my eNet setup to e.g. properly handle my blinds including cover and tilt position as well as some other things.

I've made the following improvements/changes:

Testing: I'currently testing with my own eNet setup at home: Server-Version: 2.4.0 Server-Hardware: 2 Home-Assistant: HA 2024.5.4 Num Devices: 70 DeviceTypes:

So far everything looks good from my tests. I could not test the DVT_US2M yet. I use it as my wind-sensor on the roof.

I still hope you like the improvements. It would be great to get some feedback and maybe you could test this in your environment :) Btw: Please be kind with rating my Python-Coding. This is the first time I ever really used that language....

mnordseth commented 2 months ago

Hi Chris,

This is fantastic, I am super happy that you have digged into this and made all these improvements! I am away on travel for the next few days, but will look into this once I am home!

adebree commented 2 months ago

@ChrisSoelder thanks for picking this up! I have a 40'ish device eNet setup and can help testing if you need help there. My setup consists of the following devices (the first 3 you don't listed in your setup so might be useful for testing)

DVT_S2A1 DVT_SA1Z DVT_SJAR DVT_SA1M DVT_SD1M DVT_JA1M DVT_US2M DVT_WS1BG DVT_WS3BG

eNet server software: 2.4.0 eNet Server hardware: 1 HA: 2024.6.4 (do run updates fairly soon / immediate)

mnordseth commented 2 months ago

I tested this in my setup (which is fairly basic) and it works great. I have merged the code and will publish to HACS.

ChrisSoelder commented 2 months ago

Great! I hope that it will also run well for everyone else ;)