search

mnot / redbot

REDbot is lint for HTTP resources.
https://redbot.org/
Other
535 stars 51 forks source link

Byte level care #331

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

@mnot This PR goes into "321" branch.

These commits are the result of the Integrity workflow. It cares about every byte. Please see individual commits.

Review without whitespace changes: https://github.com/mnot/redbot/pull/331/files?diff=unified&w=1

szepeviktor commented 1 year ago

I run the above workflow on each commit to keep my bytes safe.

szepeviktor commented 1 year ago

I am not sure about redbot/assets/red_style.css as it is a generated file but not minimized.

mnot commented 1 year ago

I suspect css indentation should be set to 2, just like scss. I'll do that.

mnot commented 1 year ago

Two things:

  1. I use double blank lines above Markdown section headings and between classes in Python to give visual space, so I'd prefer to leave those alone. Also, Makefile.venv is from an external source, so it shouldn't be changed.
  2. What's the motivation for not archiving development artefacts? Being able to eg download a zip from GitHub and run tests is useful.

Otherwise looks great, thanks!

szepeviktor commented 1 year ago

What's the motivation for not archiving development artefacts? Being able to eg download a zip from GitHub and run tests is useful.

I thought people using github are using git to get source code ... The purpose is not to put development files into production.

szepeviktor commented 1 year ago
  1. I use double blank lines above Markdown section headings and between classes in Python

Done 🍏

mnot commented 1 year ago

Thanks.

Re: .gitattributes - hm. I don't see archiving as the way to get to production, but if you do, you're likely to want to use something like make server to get the environment set up. Also the archive can be useful for doing things like downloading a zip to check a difference in a PR. Do these files do any harm?

szepeviktor commented 1 year ago

downloading a zip to check a difference in a PR.

This activity also resembles someone not familiar with git. ZIP archives (git archive HEAD) are usually used by package managers to download a package. It may not be true for redbot.

A second thought: redbot may not be a library but an application ...

mnot commented 1 year ago

A second thought: redbot may not be a library but an application ...

Exactly...

szepeviktor commented 1 year ago

Deleted!

mnot commented 1 year ago

Thanks!

szepeviktor commented 1 year ago

Glad to meet your bytes.