Handle SELECT DISTINCT differently

mnpenner / php-sql-parser

Automatically exported from code.google.com/p/php-sql-parser

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Handle SELECT DISTINCT differently #91

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Currently, SELECT DISTINCT statements are parsed as such:

SELECT is a node in the parse tree
DISTINCT ends up in the OPTIONS node

It would be better, if DISTINCT ends up in the SELECT node as a boolean flag 
characterizing the SELECT node.

Further, DISTINCT is not handled in the sql creator and should be added.

Original issue reported on code.google.com by adrian.p...@googlemail.com on 13 Mar 2013 at 7:45

GoogleCodeExporter commented 9 years ago

Original comment by greenlion@gmail.com on 5 May 2013 at 8:12

Changed title: Handle SELECT DISTINCT differently
Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

I have enhanced the parser, the distinct statement is now classified as 
reserved keyword. The creator should create the keywords too.

Original comment by pho...@gmx.de on 1 Nov 2013 at 9:59

Changed state: Started

GoogleCodeExporter commented 9 years ago

Ooops, I forgot the release: r391

Original comment by pho...@gmx.de on 1 Nov 2013 at 10:04

GoogleCodeExporter commented 9 years ago

Original comment by pho...@gmx.de on 2 Nov 2013 at 12:51

Changed state: Fixed