search

mnsami / composer-custom-directory-installer

A composer plugin, to install differenty types of composer packages in custom directories outside the default composer default installation path which is in the vendor folder.
https://packagist.org/packages/mnsami/composer-custom-directory-installer
MIT License
138 stars 27 forks source link

Might you want to add this to packagist? #1

Closed ddebernardy closed 10 years ago

ddebernardy commented 10 years ago

Thank you for writing this. Mind adding it to packagist.org? (Perhaps after renaming it to something more sane, e.g. "mnabil/composer-installer-plugin"?)

mnsami commented 10 years ago

You are welcome, actually I'm working on that right now! :) and I'll rename it as well

ddebernardy commented 10 years ago

how about mnabil/composer-install-anywhere for a name?

And if I may, please change those namespaces and class names to something more sane too, e.g.:

namespace MNabil\Composer\InstallAnywhere; // or whatever seems logical
use Composer\Installer\LibraryInstaller as BaseLibraryInstaller;

class LibraryInstaller extends BaseLibraryInstaller { ...
mnsami commented 10 years ago

how about mnabil\composer-custom-directory-installer for the package name?

and for the namespace, I'll take that in considerate and get back to you, because composer itself got confused, let me run some tests and get back to you.

mnsami commented 10 years ago

okay, I ran some tests, I confirm there are no conflicts or anything.

here is the namespace I used Composer\CustomDirectoryInstaller? so, what do you think? I guess it is better and more declarative than before.

ddebernardy commented 10 years ago

much better, yeah.

mnsami commented 10 years ago

okay .. gr8, I'll commit the changes right now :)

thank you very much for the suggestions