Closed bkm888 closed 6 years ago
ghost
commented
6 years ago @bkm888
Yes, system validates correctly when same account number is entered for different ledger.
Instead of hard-coding the value we are thinking of creating a 'Settings' page for update friendly approach to avoid lengthy procedure of implementing and pushing data again to production server.
ghost
commented
6 years ago @bkm888 Here is how we can take G/L account data in the report:
It gives the same result, instead of hard-coding:
Also, We have pushed the latest changes on the gcp test server. If you approve this approach we will push these changes also.
bkm888
commented
6 years ago Siddhi, ( I do not know if responding to the emails sent from github will find their way to you so I have copied Unmesh directly just in case. So, her could forward to you if it was not received.) I have attempted to run this very test on the GCP test server and the G/L Account column still comes out empty. I have attached a excel file that I exported form the report and a screenshot of the modified "Chart of Accounts". The excel file uses data from 4-4-2018 because the test server only has old data. I cannot restore a fresh set of data to it because it will destroy the other modifications we are also testing.
You will be able to see in the Chart of Accounts I have modified the parent accounts of the 3 required account heads and in the report running on the GCP Test Server (35.231.61.5) only the "Accounts Receivable" column seems to populate correctly. The "G/L Account" remains blank. I can only think of very few things that might be wrong in my test:
@bkm888 Here is how we can take G/L account data in the report:Sales and services belong to same parent accountAll the taxes have the same parent account We suggest you to assign those account numbers (If product set to “40200” and if tax set value to “23100”) to the 'Parent Account' of those accounts. Here I have done the same here, by replicating some of your accounts locally. It gives the same result, instead of hard-coding: — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
ghost
commented
6 years ago @bkm888 This particular change was not pushed on the test gcp, If this functional approach is acceptable by you we will push them up on test gcp by EOD.
bkm888
commented
6 years ago Siddhi, While this was not my first choice for a solution, it certainly seems to be the most logical way to approach the issue. So, please do move the solution to the test server for further testing. Thank you for expanding your thinking to come up with this alternative. Bryan Miles JMI Barcodes bkm@jmibarcodes.com -----Original Message----- From: "Siddhi Sawant" [notifications@github.com] Date: 05/07/2018 02:46 AM To: "mntechnique/jmi_erpnext" jmi_erpnext@noreply.github.com CC: "Mention" mention@noreply.github.com Subject: Re: [mntechnique/jmi_erpnext] Daily Sales Invoice report - G/L Account information has disappeared. (#50)
@bkm888 This particular change was not pushed on the test gcp, If this functional approach is acceptable by you we will push them up on test gcp by EOD.— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
ghost
commented
6 years ago @bkm888 we have pushed this functionality on the test server. Do let us know if there is anything that still needs attention.
Also, I suggest we can use the same approach for 'Accounts receivable' column. That way, we can have all the Accounts related columns update-friendly. (On the test server, I have made required changes for 'Accounts Receivable' column, please check and do let me know if any clarity is required.)
bkm888
commented
6 years ago Siddhi, Thank you!! Initial testing of the changes on the GCP test server appear to be working as expected. I will visit the clinet site and try it there from the test server and make sure the results match with their expectations. The only thing left at this point that must be done before I can deliver it to my client is the filtering requested in GitHub issue #43 https://github.com/mntechnique/jmi_erpnext/issues/43 Once that is ready, I can complete the final testing and allow for delivery. Thank you again. So far this is looking good. Bryan Miles JMI Barcodes bkm@jmibarcodes.com -----Original Message----- From: "Siddhi Sawant" [notifications@github.com] Date: 05/07/2018 09:03 AM To: "mntechnique/jmi_erpnext" jmi_erpnext@noreply.github.com CC: "Mention" mention@noreply.github.com Subject: Re: [mntechnique/jmi_erpnext] Daily Sales Invoice report - G/L Account information has disappeared. (#50)
@bkm888 we have pushed this functionality on the test server. Do let us know if there is anything that still needs attention. Also, I suggest we can use the same approach for 'Accounts receivable' column. That way, we can have all the Accounts related columns update-friendly. (On the test server, I have made required changes for 'Accounts Receivable' column, please check and do let me know if any clarity is required.)— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
In the earlier version of this report the column was being properly filled with the 2 account numbers for items sold and taxes. Please put this back to the way is was before the last set of changes.
If this is the result of the changes to the "Accounts Receivable Account" column, then the solution designed for that column will not work for the G/L Account column. The G/L column uses only 2 account numbers. One for all items and services sold, and another for all taxes regardless of type or jurisdiction. ERPNext would not allow every individual county and state tax to have the exact same account number.
Where the Accounts Receivable Account column is always the same (Deptors - MSD) account so the number can be applied in the chart of accounts. The same is not true for all the different sales taxes.
Please look into this again.