mntnr / name-your-contributors

Name your GitHub contributors; get commits, issues, and comments
MIT License
73 stars 20 forks source link

fix(package): fixed `engine` warning #106

Closed Berkmann18 closed 5 years ago

Berkmann18 commented 5 years ago

fix #105

Berkmann18 commented 5 years ago

@RichardLitt Do you also get the EOTP error when TravisCI is on the release stage or is just me?

RichardLitt commented 5 years ago

You mean this error? https://travis-ci.org/mntnr/name-your-contributors/jobs/535191452

Berkmann18 commented 5 years ago

Yeah, the one starting at line 577.

RichardLitt commented 5 years ago

Looks like an issue with publishing. I don't know why travis needs to publish, though - something to do with semantic release, I suppose? @gr2m might know.

Berkmann18 commented 5 years ago

@RichardLitt It's because semantic-release needs a token to publish to NPM as part of the CI workflow.

gr2m commented 5 years ago

Here is the problem

npm ERR! code EOTP
npm ERR! This operation requires a one-time password from your authenticator.
npm ERR! You can provide a one-time password by passing --otp=<code> to the command you ran.
npm ERR! If you already provided a one-time password then it is likely that you either typoed
npm ERR! it, or it timed out. Please try again.

The account requires 2-factor authentication, this won’t work with semantic-release. What I recommend to do is to create a dedicated npm account, invite it as collaborator to the name-your-contributors package, make sure it does not have 2FA enabled, then create a token with that account and store it on travis

Berkmann18 commented 5 years ago

@gr2m It's maybe because I use 2FA while being a collaborator of this repo.

gr2m commented 5 years ago

It only matters which account was used when semantic-release was setup

Berkmann18 commented 5 years ago

@gr2m Really? Surely, the account pushing the changes that are going through the CI are going to influence the use of 2FA, no?

gr2m commented 5 years ago

no, semantic-release doesn’t care who pushed changes where. It’s running in a git-enabled folder and publishes what ever is in there. I use separate npm accounts for semantic-release all the time. Many people who push the changes have 2FA enabled

Berkmann18 commented 5 years ago

Fair enough.