mntnr / name-your-contributors

Name your GitHub contributors; get commits, issues, and comments
MIT License
73 stars 20 forks source link

Code overgrabs all contributors to updated threads #14

Closed RichardLitt closed 7 years ago

RichardLitt commented 8 years ago

If someone comments on a thread three months ago, and someone else comments a day ago, both will be pulled if I am searching within the past week. This is a serious bug that devalues the stats about the size of a community. Each object will need to be date-sorted, not just the top-level issues and PRs.

RichardLitt commented 8 years ago

Assigning to myself for logging purposes, but help would be great if anyone wants to jump in!

RichardLitt commented 7 years ago

Working on this now.

RichardLitt commented 7 years ago

@tgetgood Not sure this is working. Any ideas?

$ name-your-contributors -u RichardLitt -r name-your-contributors --after=2017-10-06T01:01:01Z
{
  "prCreators": [
    [
      "dignifiedquire",
      "Friedel Ziegelmayer"
    ],
    [
      "jozefizso",
      "Jozef Izso"
    ],
    [
      "greenkeeper",
      null
    ],
    [
      "RichardLitt",
      "Richard Littauer"
    ]
  ],
  "prCommentators": [
    [
      "dignifiedquire",
      "Friedel Ziegelmayer"
    ],
    [
      "RichardLitt",
      "Richard Littauer"
    ],
    [
      "tgetgood",
      "Thomas Getgood"
    ]
  ],
  "issueCreators": [
    [
      "jbenet",
      "Juan Benet"
    ],
    [
      "gr2m",
      "Gregor Martynus"
    ],
    [
      "kentcdodds",
      "Kent C. Dodds"
    ],
    [
      "RichardLitt",
      "Richard Littauer"
    ],
    [
      "jywarren",
      "Jeffrey Warren"
    ],
    [
      "diasdavid",
      "David Dias"
    ],
    [
      "tgetgood",
      "Thomas Getgood"
    ]
  ],
  "issueCommentators": [
    [
      "RichardLitt",
      "Richard Littauer"
    ],
    [
      "gr2m",
      "Gregor Martynus"
    ],
    [
      "kentcdodds",
      "Kent C. Dodds"
    ],
    [
      "jywarren",
      "Jeffrey Warren"
    ],
    [
      "diasdavid",
      "David Dias"
    ]
  ]
}
tgetgood commented 7 years ago

The filtering works, the problem is that long options don't. I'll put in a patch for that.

If you try with -a instead of --after I think this works as expected.