mnubo / kubernetes-py

A python module for Kubernetes.
Apache License 2.0
123 stars 46 forks source link

"kubernetes" is overloaded #124

Closed trondhindenes closed 5 years ago

trondhindenes commented 6 years ago

It would probably be better to name the lib kubernetes_py or something, kubernetes is already the name of the official kubernetes client.

eisjcormier commented 6 years ago

+1

sebastienc commented 6 years ago

I agree, we're going to rename it.

varac commented 6 years ago

Yes please - I have the official "kubernetes" python package installed next to "kubernetes-py". powerline-kubernetes tries to:

from kubernetes import K8sConfig

which fails with:

ImportError: cannot import name K8sConfig

Here in ipython:

In [1]: import powerline_kubernetes
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-67be6e01478c> in <module>()
----> 1 import powerline_kubernetes

/usr/local/lib/python2.7/dist-packages/powerline_kubernetes/__init__.py in <module>()
----> 1 from .segments import kubernetes  # noqa

/usr/local/lib/python2.7/dist-packages/powerline_kubernetes/segments.py in <module>()
      1 # vim:fileencoding=utf-8:noet
      2 from powerline.segments import Segment, with_docstring
----> 3 from kubernetes import K8sConfig
      4 
      5 class KubernetesSegment(Segment):

ImportError: cannot import name K8sConfig

So renaming soon is much appreciated!

sebastienc commented 5 years ago

Hi everyone,

Hopefully this will help you.

Happy holidays.

varac commented 5 years ago

@sebastienc Great, thanks!

ftr, this is the new kubernetes-py package on pypi.org: https://pypi.org/project/kubernetes-py/