mnurzia / even-better-ls

LS + Icons + Formatting
486 stars 31 forks source link

Icons don't display using ls (iTerm2 on Mac OS X 10.12) #18

Open heyitsols opened 7 years ago

heyitsols commented 7 years ago

Hello

I am using Mac OS X 10.12 and iTerm2 as my terminal emulator

Running ls_colors_generator shows the icons as expected, however running the patched ls binary doesn't seem to respect the LS_COLORS variable

The patched ls output is different from the system ls, so I know that this is the binary being used. For clarity, here is an md5 of the file if comparison is needed, not sure what other information you would need to assist with this

 in ~ md5 /Users/ole09/bin/lsi
MD5 (/Users/ole09/bin/lsi) = 6228598ea957078cc985ffb684cc5e9f

Thanks,

Oliver

mnurzia commented 7 years ago

Are you sure that you have nerd-fonts installed? You can get a compatible font here.

heyitsols commented 7 years ago

Yep, the fonts are definitely there, as the ls_colors_generator displays them fine

screen shot 2017-06-28 at 11 20 32

edit

Even the colours don't work

LS_COLORS=$(ls_colors_generator)
run_ls() {
  lsi --color=auto -w $(tput cols) "$@"
}
alias ls="run_ls"

screen shot 2017-06-28 at 12 15 47

heyitsols commented 7 years ago

Found it, the LS_COLORS needed exporting too

Would you be averse to a PR that will set some variables and additional commands if the host is a Mac?

heyitsols commented 7 years ago

19 Add additional commands if install target is macOS

avshyz commented 6 years ago

bump?

Noammac commented 6 years ago

Dev is dead, get a fork

On Thu, 5 Apr 2018, 22:56 Avishay Zarad, notifications@github.com wrote:

bump?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/illinoisjackson/even-better-ls/issues/18#issuecomment-379057644, or mute the thread https://github.com/notifications/unsubscribe-auth/ASpZqz77gR_Y58oEUQQJXMvu5hn2GeIqks5tlnbygaJpZM4OFDJF .

chrisvacc commented 5 years ago

@muggahtee, does your commit work with Mojave?

I’ve never cloned a commit before but this isn’t working:

git clone https://github.com/mnurzia/even-better-ls.git -b mac_os_script_changes ~/even-better-ls-mac
Cloning into '/Users/chrisvaccaro/even-better-ls-mac'...
fatal: Remote branch mac_os_script_changes not found in upstream origin

Or is it just better to clone ev0rtex/even-better-ls

heyitsols commented 5 years ago

This project is dead it seems. But the above branch only exists on my fork (so replace mnurzia with muggahtee)

However, I’d recommend LSD which is similar but maintained