mnurzia / even-better-ls

LS + Icons + Formatting
486 stars 31 forks source link

'ST_NBLOCKSIZE' undeclared #29

Open crscillitoe opened 6 years ago

crscillitoe commented 6 years ago

Distribution: Arch

image

I get this error here when I run sh -c "$(curl -fsSL https://raw.githubusercontent.com/illinoisjackson/even-better-ls/master/install.sh)"

Noammac commented 6 years ago

Did you get the correct coreutils version?

On Sat, 17 Mar 2018, 22:09 crscillitoe, notifications@github.com wrote:

Distribution: Arch

[image: image] https://user-images.githubusercontent.com/22220179/37559477-75f5a952-29fd-11e8-886d-a179faaba37e.png

I get this error here when I run sh -c "$(curl -fsSL https://raw.githubusercontent.com/illinoisjackson/even-better-ls/master/install.sh )"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/illinoisjackson/even-better-ls/issues/29, or mute the thread https://github.com/notifications/unsubscribe-auth/ASpZqxRXlRHW58fSpMOwbmQialHg9ND_ks5tfW1ugaJpZM4Su8mV .

crscillitoe commented 6 years ago

I don't see why I wouldn't. I just ran his script I didn't change anything.

Noammac commented 6 years ago

If you're using the script you definitely haven't got the correct coreutils version. The version in the install script is 8.29 while ls.c comes from 8.2

On Sat, 17 Mar 2018, 22:13 crscillitoe, notifications@github.com wrote:

I don't see why I wouldn't. I just ran his script I didn't change anything.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/illinoisjackson/even-better-ls/issues/29#issuecomment-373949309, or mute the thread https://github.com/notifications/unsubscribe-auth/ASpZq3m91bwfFmZPim35h130ew2FgV84ks5tfW5wgaJpZM4Su8mV .

crscillitoe commented 6 years ago

So his script is broken? I'll try using coreutils 8.2 I guess

Noammac commented 6 years ago

Yeah, Illinois accepted a commit that changed the coreutils version without changing the ls.c version.

There's ls.c for 8.28 in my fork, but that's as modern as it gets AFAIK. Also, it has some issues I hope someone competent would know how to fix.

aboutroots commented 6 years ago

In case anyone is interested and if it's OK for you to use an older version, a quick fix to make it to work is to clone the repo and replace the non-working version with 8.2 in the install.sh script before running it.

calston commented 6 years ago

So @dkarter broke it?