Open spollard opened 2 years ago
One other fun thing: You may want to clean all of the bin/, lib/, and lib64/ items from the sandstorm-files.list file, since bin, lib, and lib64 are all now symlinks now (do not delete them), but the files under them are not. See https://github.com/sandstorm-io/sandstorm/issues/3535
You won't see the issue until you try to pack the SPK, but I would delete: https://github.com/mnutt/davros/blob/b3119e2de28d197ff87d3dfbb252bdc9975d76f7/.sandstorm/sandstorm-files.list#L6-L12 https://github.com/mnutt/davros/blob/b3119e2de28d197ff87d3dfbb252bdc9975d76f7/.sandstorm/sandstorm-files.list#L64-L100 https://github.com/mnutt/davros/blob/b3119e2de28d197ff87d3dfbb252bdc9975d76f7/.sandstorm/sandstorm-files.list#L102
OK I made those changes!
I see that opt/app/sandstorm-integration/bin/getPublicId
has been removed from sandstorm-files.list. I'm guessing that'll be added back when sandstorm-files.list is updated at release time?
Awesome, thank you for this! Looks great at first glance.
IIRC the getPublicId
binary is necessary for publishing grains, but yeah I can exercise that functionality before release to make sure it gets added back.
Updated clang version to 9. I clicked around a bit to make sure things worked, but not major testing.