search

mnutt / davros

Personal file storage server
Apache License 2.0
298 stars 35 forks source link

upload files from mobile #25

Open JamborJan opened 8 years ago

JamborJan commented 8 years ago

When using davros on a mobile phone via web you can see the upload button but nothing happens when you tap it.

image1

Tested with iOS 9.2 on an iPhone 6S

Current behavior: nothing happens

Expected behavior: dialogue asking for access to pictures on the phone. possibility to upload one or more pictures.

I'm not sure if that works and you can get access to the files with the mobile safari browser.

ocdtrekkie commented 8 years ago

Last time I checked it didn't work on desktops either. :P Though it might have been fixed.

JamborJan commented 8 years ago

I have been using it on desktop and it worked (not in IE, there I get a 404 when clicking on the files section).

mnutt commented 8 years ago

Ah, I think I've been able to track this one down. We create a dummy <input id=file type=file> on the page and when you tap the upload menu item, it essentially calls $('file').trigger('click'). Desktop clients allow this, but iOS doesn't.

So it probably involves actually rendering the transparent <input> on top of the 'upload' item. I'm thinking maybe it warrants some UX changes to make it work well. It may take a little while.

JamborJan commented 8 years ago

This is less an issue for me since mobile clients are working now.

mnutt commented 8 years ago

This seems to be an issue on chrome/linux as well, so will probably get fixed sooner rather than later.

troyjfarrell commented 6 years ago

Upload works on Firefox and Chrome on Android 8. Upload does not work on Safari on iOS 11.

troyjfarrell commented 6 years ago

Actually, I was wrong. It does not work on the mobile browsers at all. It seems that the menu item has a bug in the event handling, likely in ember-paper. This bug occurs only in mobile mode, so it seems that that mobile browsers aren't responding properly to the event, but it can be reproduced on Chrome simply by resizing the window.

I will continue to investigate.