search

mnutt / davros

Personal file storage server
Apache License 2.0
298 stars 35 forks source link

'#' in file and folder names causes problems #33

Open timhowes opened 8 years ago

timhowes commented 8 years ago

If I enter a folder name in the web interface containing #, everything after # is ignored (treated as a comment?). If a file or folder is synced from the local folder using owncloud, it shows up in the web interface, but clicking on it leads to a 404.

Sniper-SnX commented 7 years ago

Happens for me too. Unfortunately i put some files containing # to one of my davros installs via sync client (Syncovery) but am not able to delete of view or download them afterwards, although they exist physically. WebUI and sync client cannot acces them. (Tried both).

garrison commented 3 years ago

& is another character that causes problems. Also related to #15.

zenhack commented 3 years ago

These are characters that have special meaning in URLs; I would hazard a guess that fixing this is just a matter of putting encodeURIComponent/decodeURIComponent in the right places.

mnutt commented 3 years ago

I see the issue; generally we automatically uri-encode things but creating a new directory puts the new directory name in the path of a MKCOL. Should be a straightforward fix.

garrison commented 3 years ago

Fyi, for me the & was in a filename, not a folder name. (Specifically, I uploaded a file named b&w.png, but clicking on it led to a 404.)