search

mnutt / davros

Personal file storage server
Apache License 2.0
298 stars 35 forks source link

No app icon in Edge: sandstorm-pkgdef.capnp declares that jpegs are actually pngs #72

Open zarvox opened 7 years ago

zarvox commented 7 years ago

Sandstorm serves app icons from its static endpoint. It believes the content-type that was specified by the package metadata, and does not perform content-sniffing.

There are some JPEG files that are included in the pkgdef but are described as PNGs. This results in Sandstorm serving the bytes of a JPEG with a Content-Type: image/png.

Most browsers seem to ignore the Content-Type header and sniff the filetype of the content, and wind up showing . However, Microsoft Edge (and possibly IE?) trust that the header the browser sent is accurate, and fail to render the app icon at all.

mnutt commented 7 years ago

Good catch, thanks. I'll make sure this gets fixed in the next release.

ocdtrekkie commented 4 years ago

This seems to still be unfixed, although the new Edge is based on Chromium, so people are unlikely to experience this issue.