search

mnylc / islandora_multi_importer

This is a flexible, twig based, all cmodel, tabular data to islandora Object importer with optional ZeroMQ processing
GNU General Public License v3.0
16 stars 15 forks source link

IMI and Default XSLTs #68

Open petermacdonald opened 6 years ago

petermacdonald commented 6 years ago

The great IMI module offers to apply the "default XMLTs" for crosswalking MODS to DC, but I can't seem to get it to ever work.

I set my XML form settings to use the default XSLTs for all forms, but that doesn't seem to fix it either.

Is there something else I should do?

I'm using Islandora 7-x.10 modules and IMI cloned about a month ago.

This is not critical, because I know how to do the crosswalk after ingest using a secret weapon I got from Mark McFate.

DiegoPino commented 6 years ago

@petermacdonald you need to set my XML form settings to use the default XSLTs for all CMODELS that apply, that last step is annoying but needed on the XML side. Latest version of IMI applies a MODS cleanup XSLT and a pull that will go out this week to IMI applies a general one in case you select "default XMLTs" and XML forms "default XSLTs " for a given CMODEL is disabled.

DiegoPino commented 6 years ago

Any feedback on this? If not will close

petermacdonald commented 6 years ago

I understand your explanation, Diego. Thank you.

I'll continue for now using my own method for for doing the crosswalks and I'll look forward to updating the IMI some time.

Peter

On Tue, May 1, 2018 at 11:29 AM, Diego Pino Navarro < notifications@github.com> wrote:

Any feedback on this? If not will close

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mnylc/islandora_multi_importer/issues/68#issuecomment-385700180, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqWGYUPYXlZHR7WejfrNKxT5587QeoKks5tuH9hgaJpZM4TlIP8 .

-- Peter MacDonald, Library Information Systems Specialist Hamilton College Library Clinton, New York 315 859-4493 pmacdona-hamilton (Skype)

McFateM commented 6 years ago

@petermacdonald @DiegoPino and I discussed a related issue with this today and I'd like to use this open issue to address my problem too. The problem I'm having is that when I select "default XSLTs" to satisfy IMI then the self-transform I need to run when XML forms are used goes missing. One solution that @DiegoPino and I discussed today is to provide a hook that allows a user to override the usual XSLTs provided by IMI, thereby allowing that user to NOT specify "default XSLTs" just to satisfy IMI. That would then allow the XSLTs assigned to various XML forms to remain active when those forms are used.

So, I'm working on a hook implementation now that I'll try to build in a new issue_68 branch of this code.

McFateM commented 6 years ago

OK, I've abandoned the hook idea... hooks and class _constructors just don't seem to play together in Drupal. So, instead I'm implementing some Drupal varialble overrides. Examples of my own implementation include:

vagrant@dgadmin:/var/www/drupal7/sites/default/modules/dg7/xslt$ drush vset islandora_multi_importer_mods_to_dc 'sites/default/modules/dg7/xslt/mods_to_dc_grinnell.xsl'
islandora_multi_importer_mods_to_dc was set to "sites/default/modules/dg7/xslt/mods_to_dc_grinnell.xsl".                                                                                                                             
vagrant@dgadmin:/var/www/drupal7/sites/default/modules/dg7/xslt$ drush vset islandora_multi_importer_mods_cleanup 'sites/default/modules/dg7/xslt/cleanup_mods_and_reorder.xsl'
islandora_multi_importer_mods_cleanup was set to "sites/default/modules/dg7/xslt/cleanup_mods_and_reorder.xsl".                                                                                                                      
vagrant@dgadmin:/var/www/drupal7/sites/default/modules/dg7/xslt$ drush vset islandora_multi_importer_modsself TRUE
islandora_multi_importer_modsself was set to TRUE.

Unfortunately, it looks like this combination of variables causes some necessary XML form code to not be loaded... 

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: /batch?id=6970&op=do StatusText: OK ResponseText: ( ! ) Fatal error: Call to undefined function xml_form_builder_transform_document() in /var/www/drupal7/sites/all/modules/contrib/islandora_multi_importer/includes/islandora_multi_batch.inc on line 709

So I am addressing that now. Hope to have a working PR very soon.