search

mnylc / islandora_multi_importer

This is a flexible, twig based, all cmodel, tabular data to islandora Object importer with optional ZeroMQ processing
GNU General Public License v3.0
16 stars 15 forks source link

Issue 95: i really like my DC to be generated please #97

Closed DiegoPino closed 5 years ago

DiegoPino commented 5 years ago

My first humble attempt on actually triggering the MODS to DC when global DC transform is not enabled. It's still -humble- and I would like to generalize the code a bit more. This is only for ingests yet, not for updates. Also deals with the elusive & so missing, COLLECTION POLICY.

I have not tested the code still, mostly blindly coded, but after a few nightly passes, it should work. Will keep on working on this tomorrow AM and final, merge-able version, should go into master soon after that.

NOTE: I did not indent code that was not touched to avoid cluttering any code review, you (me expecting) could help me doing here.

DiegoPino commented 5 years ago

@patdunlavey could I ask you to test this? The procedure is simple. 1.- Disable Default DC XSLT from Islandora XML forms settings form (save) 2.- Run any ingest (try with a few objects and a collection?) selecting default DC XLST for the DC datastream. I added an empty Collection policy creation in this pull too. Only if you have some time of course. Thanks a lot

patdunlavey commented 5 years ago

@DiegoPino I will test this today and report back. Thanks!

DiegoPino commented 5 years ago

I'm going to merge this so i can push your scheme storage changes and also the datastream label = filename fix. Thanks for testing @patdunlavey