search

mnzaki / coolsoft-13

Coolsoft 2013
0 stars 0 forks source link

S4.15: As a guest/registered user i can view the trending ideas. #221

Closed hesham9 closed 11 years ago

hesham9 commented 11 years ago

Tasks: Research different algorithms and implement a final one. 8 Tests 2 UML 1 UI 1 Documentation 1

Success: 1- 4-5 Trending ideas will be displayed. 2- Trending ideas will be calculated according to some standard. 3- Trending ideas will be updated in real-time.

mnzaki commented 11 years ago

@hesham9 please fix the labels of this issue. Look at my inline comments. Reopening documentation and tests.

mnzaki commented 11 years ago

Apologies. Just realized I only review tests here. I will remove the doc-reopen label, but nonetheless you should consider my comments.

hishamelgezeery commented 11 years ago

@hesham9 please update your labels.

hishamelgezeery commented 11 years ago

@hesham9 you have two create create_trends migrations with two different timestamps in your branch. The one not in master has a default value for int columns, which means bad reviewing at my side. So to resolve this, delete the migration not in master, and for the one in master, set the default to 0 for int columns, so that when your merged with master the migration is updated. A not so good solution but a solution.

hesham9 commented 11 years ago

@linabasheer re-check code please. @hishamelgezeery done.

linabasheer commented 11 years ago

@hesham9 doc verified

hesham9 commented 11 years ago

@linabasheer re-check code please :D

linabasheer commented 11 years ago

@hesham9 code verified

MahmoudAAbdelwahab commented 11 years ago

@hesham9 tests fail please recheck them again

hishamelgezeery commented 11 years ago

Scenario verified.

MahmoudAAbdelwahab commented 11 years ago

@hesham9 sorry had a problem with migrating and preparing the db, however tests now run! Test verified (Y)

hesham9 commented 11 years ago

@linabasheer merged master into my branch re-check code please.

linabasheer commented 11 years ago

@hesham9 code verified

Mo7amedSala7Nazir commented 11 years ago

@hesham9 you have multiple issues 1- you don't apply the convention in the blocks name 2- The lines aren't touching the timeline. 3- The opt block has to be specified for one of the MVCs

hesham9 commented 11 years ago

@Mo7amedSala7Nazir UML fixed please review.

Mo7amedSala7Nazir commented 11 years ago

@hesham9 sorry but the timelines are still messy

hesham9 commented 11 years ago

@Mo7amedSala7Nazir what exactly is messy with the timelines?

hesham9 commented 11 years ago

@linabasheer review please :D.

hesham9 commented 11 years ago

@muhammedabuali 12 hours has passed since @Mo7amedSala7Nazir reviewed my UML. tagging another reviewer now.

linabasheer commented 11 years ago

@hesham9 code verified

muhammedabuali commented 11 years ago

UML reopen the opt block is not positioned correctly

hesham9 commented 11 years ago

@muhammedabuali fixed now re-check please :D.

muhammedabuali commented 11 years ago

UML verified