mnzaki / coolsoft-13

Coolsoft 2013
0 stars 0 forks source link

S4.10: As an Idea Submitter / Committee, from the dashboard I can view a graph comparing ideas from a certain tag with ideas in the same tag. #92

Closed linabasheer closed 11 years ago

linabasheer commented 11 years ago

Task: 1.search 2.create graph 3.GUI 4.Write test code

  1. Draw UML 6.Create documentation Success Demo: 1.user chooses tag and two buttons will appear one for the bubble chart and one for the column chart 2.user clicks on bubble chart a graph will appear having my idea with 20 top ideas in the chosen tag 3.user clicks on column chart a graph will appear having my idea with 20 top ideas in the chosen tag Faliure Demo : 1.The committee member enters the dashboard, however there are neither ideas yet submitted by him nor in the tags he is assigned to.In this case the overall view would be there (e.g the buttons, the tag's filter) however in the part of displaying any results, There will be a statement saying that there are no ideas posted yet.And whenever he tries to choose a tag to display its results, a modal dialog appears stating that this tag is empty.
hishamelgezeery commented 11 years ago

@linabasheer Everthing seems to work fine, but I have to open this because it should be integrated with my branch and salah's branch to work correctly. Scenario-reopen

hishamelgezeery commented 11 years ago

By the way disregard the first line of the previous comment, I don't know how that got there :D

marwa-mehanna commented 11 years ago

@linabasheer . please recheck you documentation,i think you need to add params, check indentation in index.html.erb. check in the dashboard controller the #s,if they are not needed please remove.

Mo7amedSala7Nazir commented 11 years ago

@linabasheer you didn't perform the correct UML for your special type of view.

hesham9 commented 11 years ago

@linabasheer tests fail.

linabasheer commented 11 years ago

@hesham9 corrected test please review

hesham9 commented 11 years ago

@linabasheer test verified.

linabasheer commented 11 years ago

@Mo7amedSala7Nazir corredted UML please review

linabasheer commented 11 years ago

@marwa-mehanna my method doesnt have paramateres it is salah's indentation you asked for is not in my files

linabasheer commented 11 years ago

@Mo7amedSala7Nazir I corrected UML

linabasheer commented 11 years ago

@marwa-mehanna please review my code as i merged with another branch

marwa-mehanna commented 11 years ago

@linabasheer code verified.

Mo7amedSala7Nazir commented 11 years ago

@linabasheer UML verified :+1:

hishamelgezeery commented 11 years ago

@linabasheer Scenario verified. merging

marwa-mehanna commented 11 years ago

@linabasheer doc verified, please check in line comment

hishamelgezeery commented 11 years ago

@linabasheer what does the x-axis in the bubble graph represent? Could you edit the layout of dashboard page? Meaning that when the graphs are displayed, they are push further down the page, but not next to the tags. That's the only problem, fix it and then you're verified :D

Scenario reopened.

linabasheer commented 11 years ago

@hishamelgezeery the x-axis of the bubble chart is idea id because if i didnt put it all the bubbles will be on the same line i tried to display it next to tags but when i do this bar and bubble tabs go up in the lamp container do you have any solution for this ?

Mo7amedSala7Nazir commented 11 years ago

@linabasheer you need to include the if condition for which graph will appear

linabasheer commented 11 years ago

@marwa-mehanna I added font awesome plz review

linabasheer commented 11 years ago

@Mo7amedSala7Nazir i added the condition in the UML please review

hesham9 commented 11 years ago

@linabasheer can't find the tests.

linabasheer commented 11 years ago

@hishamelgezeery I changed the position of the graph please review

hishamelgezeery commented 11 years ago

Scenario verified

marwa-mehanna commented 11 years ago

@linabasheer code verified

linabasheer commented 11 years ago

@hesham9 plz review test

Mo7amedSala7Nazir commented 11 years ago

@linabasheer modify timelines :D this is the only problem in this UML

linabasheer commented 11 years ago

@Mo7amedSala7Nazir i modified UML please review

hesham9 commented 11 years ago

@linabasheer reviewing now.

hesham9 commented 11 years ago

@linabasheer tests verified.

Mo7amedSala7Nazir commented 11 years ago

@linabasheer UML verified

hishamelgezeery commented 11 years ago

@linabasheer Scenario verified.

marwa-mehanna commented 11 years ago

@linabasheer code verified