Closed linabasheer closed 11 years ago
@linabasheer Everthing seems to work fine, but I have to open this because it should be integrated with my branch and salah's branch to work correctly. Scenario-reopen
By the way disregard the first line of the previous comment, I don't know how that got there :D
@linabasheer . please recheck you documentation,i think you need to add params, check indentation in index.html.erb. check in the dashboard controller the #s,if they are not needed please remove.
@linabasheer you didn't perform the correct UML for your special type of view.
@linabasheer tests fail.
@hesham9 corrected test please review
@linabasheer test verified.
@Mo7amedSala7Nazir corredted UML please review
@marwa-mehanna my method doesnt have paramateres it is salah's indentation you asked for is not in my files
@Mo7amedSala7Nazir I corrected UML
@marwa-mehanna please review my code as i merged with another branch
@linabasheer code verified.
@linabasheer UML verified :+1:
@linabasheer Scenario verified. merging
@linabasheer doc verified, please check in line comment
@linabasheer what does the x-axis in the bubble graph represent? Could you edit the layout of dashboard page? Meaning that when the graphs are displayed, they are push further down the page, but not next to the tags. That's the only problem, fix it and then you're verified :D
Scenario reopened.
@hishamelgezeery the x-axis of the bubble chart is idea id because if i didnt put it all the bubbles will be on the same line i tried to display it next to tags but when i do this bar and bubble tabs go up in the lamp container do you have any solution for this ?
@linabasheer you need to include the if condition for which graph will appear
@marwa-mehanna I added font awesome plz review
@Mo7amedSala7Nazir i added the condition in the UML please review
@linabasheer can't find the tests.
@hishamelgezeery I changed the position of the graph please review
Scenario verified
@linabasheer code verified
@hesham9 plz review test
@linabasheer modify timelines :D this is the only problem in this UML
@Mo7amedSala7Nazir i modified UML please review
@linabasheer reviewing now.
@linabasheer tests verified.
@linabasheer UML verified
@linabasheer Scenario verified.
@linabasheer code verified
Task: 1.search 2.create graph 3.GUI 4.Write test code