S2.8 : As an Admin I can add/delete a synonym to a tag

[mohammad-abdulkhaliq]

Tasks : User Interface (modal dialog) Delete Synonym option Testing, Sketches

Success Scenario :

1.The Admin clicks on Tag Management option on the admin navbar. 2.The Admin chooses the tag he wishes to add a synonym to. 3.The Admin recieves a modal dialog which displays the synonym list. 4.The admin can then write the name of the synonym and recieves the response.

5. The admin clicks an x on the sym in the list and it is deleted from the tag.

Failure Scenario :

1.The Sym already exists as a Tag but is not in the selected Tag's sym list,then it is added to Tag's Sym list. 2.The Sym already exists in the Tag's sym list, is not added and the admin is notified so in the textbox where he entered the sym name. 3.The Sym has the same name of the tag cannot be added and the admin is also notified on the textbox.

[mohammad-abdulkhaliq]

This issue was already started in Issue #2.3 As an Admin I can create/edit a Tag, this is the continuation of the Issue with UI.

[mohammad-abdulkhaliq]

@DevYah @mnzaki
Request to change the success scenario of this story.

This is a new story added after sprint 0

Problem : Displaying all synonyms of a tag in a modal does not make sense if we have a large number of synonyms so It should be changed to deleting a synonym can be done by clicking delete option on the show tag view which holds the synonyms of tag displayed as a table.

Should this request be posted on the mailing list too ?

[mnzaki]

@mohammad-abdulkhaliq Displaying them in another page is the first step of implementing a modal dialog anyway, so go ahead and do that. I remember we actually decided that there would be a tag management page or something like so?

[mohammad-abdulkhaliq]

@mnzaki Yes exactly that is actually already done. What I mean that the modal would only be used to add a synonym not coupled with delete actions for every other synonym.

[mnzaki]

@mohammad-abdulkhaliq you'll most probably just end up rendering the tag management page in a modal dialog using ralis' unobtrusive JS techniques.

IOW go ahead and do that.

[mohammad-abdulkhaliq]

hmmm.. Seems like a good idea, I will try.

On Sat, Apr 6, 2013 at 4:57 PM, Mina Nagy Zaki notifications@github.comwrote:

@mohammad-abdulkhaliq https://github.com/mohammad-abdulkhaliq you'll most probably just end up rendering the tag management page in a modal dialog using ralis' unobtrusive JS techniques.

IOW go ahead and do that.

— Reply to this email directly or view it on GitHubhttps://github.com/DevYah/coolsoft-13/issues/97#issuecomment-15997465 .

[msameh93]

@mohammad-abdulkhaliq Still the same problem. I've been waiting on bundle install for over 15 minutes :D !! Please try to fix it

[omar-kassem]

There is four failures in the tag test file

[yahiaelgamal]

@mohammad-abdulkhaliq This is not labeled properly. Where are scenario,doc, code, uml labels.

[msameh93]

@mohammad-abdulkhaliq Can't sign in. Please fix Devise. Scenario reopen

[mohammad-abdulkhaliq]

@muhammedabuali UML

[mohammad-abdulkhaliq]

@msameh93 email : a@gmail.com password : a

[msameh93]

@mohammad-abdulkhaliq Scenario verified !!

[mnzaki]

@mohammad-abdulkhaliq please git rm all .coffee files. Do not add coffee script files. Also re-add .gitignore to this branch. I'd suggest you also merge master now.

[mnzaki]

Redocument the entirety of tags_controller and follow the guideline here word for word: Spaces, tabs, +param+:: syntax. Do not add random asterisks (*) and arrows (->).

This does not valid documentation make:

# POST /tags 
# POST /tags.json

Reopening documentation.

[omar-kassem]

you still have failures

[mohammad-abdulkhaliq]

@mnzaki I apologize for the late reply, I will get to it as soon as possible

[mohammad-abdulkhaliq]

@msameh93 @mnzaki @muhammedabuali @omar-kassem

Use this branch C2_mohammadabdulkhaliq#41_create/edit_tag_reopened (Double pull request)

[muhammedabuali]

code reopen , merge master , restore gitignore , @mohammad-abdulkhaliq

[mohammad-abdulkhaliq]

@muhammedabuali ok

[mohammad-abdulkhaliq]

@muhammedabuali code, uml pending

[mohammad-abdulkhaliq]

@muhammedabuali Note : Make sure to look only at the create/edit_tag branch, I forget to mention this issue in the commits but the old #97 branch is no longer used.

[mohammad-abdulkhaliq]

@msameh93 To test this use

C2mohammad-abdulkhaliq#41_create_edit_tag_reopened

[mohammad-abdulkhaliq]

@hishamelgezeery please review

[hishamelgezeery]

Scenario verified.

[muhammedabuali]

please check my comments on the pull request @mohammad-abdulkhaliq

[mohammad-abdulkhaliq]

@muhammedabuali Code Pending in the Issue #41 branch

[muhammedabuali]

code verified , make sure the scenario is still verified

[mnzaki]

Outdated Duplicate. Closing.