search

mo-ah-dawood / fcm_config

10 stars 12 forks source link

make required parameter as required in init method #18

Closed binSaed closed 2 years ago

maxzod commented 2 years ago

why ?

binSaed commented 2 years ago

@maxzod why not use language features? I really didn't know if this parameter is required until I read source code

binSaed commented 2 years ago

but if it is marked as required, the dart analyzer will tell me to add this parameter

maxzod commented 2 years ago

it would be great to update the readme too 👍

binSaed commented 2 years ago

Actually, I don't know the details of why we need to make it required, so I can't update the readme wait for @mo-ah-dawood if he has more details

mo-ah-dawood commented 2 years ago

to use the same channel for both foreground and background i changed it to defaultAndroidChannel that accepts object of AndroidNotificationChannel so you can test it and tell me i will upload it after your test