mo-renike / herroyalpianist.github.io

0 stars 1 forks source link

observations on the recent update to your Bandittude page #3

Open Johndiddles opened 3 years ago

Johndiddles commented 3 years ago

Omo'ya mi wossop

I just viewed your Bandittude homepage and its really nice. I noticed some things.

  1. you should give your navbar a background. It can be the same thing with the background for the main page so that when the viewer scrolls up and down the page, he can always see the navbar clearly. at the moment, if you scroll up, you will notice that the scrollable contents especially images make it hard to see the navbar. that's because the navbar is transparent.

  2. Transition: these nice images move too fast. you can increase it to 5s so the viewer can at least get a good glance at the images before the next ones pop in.

  3. Image sizes: I was thinking the images in that slider should fill the containing div tag while the containing div itself is set to a fixed with or set to occupy the screen width. overflow can be set to "hidden" or "scroll" so that the whole page still gets to sit within the screen width.

Bandittude

Johndiddles commented 3 years ago

also, its like the active link css only applies to the home tag. when you visit other pages, the home link in the navbar still appears as an active link instead