search

mo29cg / nvda-chatGPT

15 stars 7 forks source link

Encoding errors #14

Closed CyrilleB79 closed 1 year ago

CyrilleB79 commented 1 year ago

There are various text encoding errors in this add-on.

Issue 1:

I send: "Bonjour, parles-tu français?" as first request. In the dialog list, I get the following text: You : Bonjour, parles-tu français?

Issue 2

After a while in the conversation, there are also encoding issues in the ui.browseableMessage, e.g.: Je suis désolé The encoding errors are always worse when the conversation becomes longer.

Note: I do not know if it is related to some encoding config in my system; I think that it should be cp1252.

Issue 3:

Looking at the code, I can see that you use a markdown module. However, this seem to create issues as follows. If I ask: "Could you give me an example on how to write markdown titles" In the `ui.browsableMessage, I get the titles detected by NVDA rather than the markdown source code to create them, e.g.:

# Title 1
## Title 2

I do not know why you use markdown, but maybe some sort of escaping is missing somewhere.

Thanks.

mo29cg commented 1 year ago

Regarding encoding issues, can you try the latest version to see if it still occurs on it? https://github.com/mo29cg/nvda-chatGPT/releases/latest/download/nvdaChatGPT.nvda-addon

I should've fixed that a little ago, but I didn't figure out how to make it automatically upgrade yet, so you're probably using the older version. I'm planing to learn how to post to the official add-on database or something, but I'm busy.

Regarding markdown, chatGPT outputs natively texts with markdown syntax, like when it outputs source codes or lists. So I thought it's more convenient to process it, I prefer to keep it that way right now.

CyrilleB79 commented 1 year ago

OK. The two first issues do not seem to occur anymore; it was occurring each time before.

The third issue does not occur anymore either. However, it's hare to test two times the same thing with ChatGPT since its answer may differ even if the request is the same. So I do not know if it has been fixed by the add-on or if the issue was an artifact of ChatGPT.

Anyway, I can close this ticket. If I encounter any issue, I will open a new one. Thanks.

PS: Submitting to the add-on store is now very easy: only 4 fields in a form to fill.