search

mo4islona / node-blockly

Blockly for Node.js and Browser via CommonJS module
133 stars 81 forks source link

Replacing xmldom with jsdom & xmlshim #16

Closed fermuch closed 6 years ago

fermuch commented 6 years ago

This should solve #15

The test suite runs except for the domToText and domToPrettyText, which I'm not sure what's failing. To me, it seems the strategy of using replace to clear the produced object is inefficient, and I would only check if the resulting string's length is >0, but I'd like to have your opinion before modifying the tests.

mo4islona commented 6 years ago

It doesnt work. What version do you use to build deps?

node -v v8.7.0

yarn yarn install v1.2.1 [1/4] 🔍 Resolving packages... [2/4] 🚚 Fetching packages... [3/4] 🔗 Linking dependencies... [4/4] 📃 Building fresh packages... [1/1] ⠂ libxmljs [-/1] ⠂ waiting... [-/1] ⠂ waiting... [1/1] ⠂ libxmljs [1/1] ⠁ libxmljs [-/1] ⠁ waiting... [-/1] ⠁ waiting... [-/1] ⠁ waiting... [3/4] 🔗 Linking dependencies... warning "eslint-plugin-react@6.10.3" has unmet peer dependency "eslint@^2.0.0 || ^3.0.0". [1/1] ⠂ libxmljs [1/1] ⠄ libxmljs [-/1] ⠄ waiting... [-/1] ⠄ waiting... [-/1] ⠄ waiting... success Installed "node-gyp@3.6.2" with binaries:

  • node-gyp error /Users/mo4islona/Projects/node-blockly/node_modules/libxmljs: Command failed. Exit code: 127 Command: node-gyp rebuild Arguments:
fermuch commented 6 years ago

Here you can use the exact version I'm using, with package-lock to keep the same dependencies as mine: https://github.com/fermuch/node-blockly/tree/temp-fork