search

mo4islona / node-blockly

Blockly for Node.js and Browser via CommonJS module
135 stars 81 forks source link

Latest blockly version: goog is not defined #36

Closed greyivy closed 4 years ago

greyivy commented 4 years ago

When trying to use this package with the latest version of blockly, I get the following error (via test and server use):

ReferenceError: goog is not defined

greyivy commented 4 years ago

This seems to have fixed it, although I'm not sure if it has the potential to break anything: https://github.com/greyivy/node-blockly/commit/ad63265fd5723f2ecefbe5c26da255264490c3f2

mo4islona commented 4 years ago

Could you provide code that produce such error?

greyivy commented 4 years ago

The included test (via npm test) should produce it if Blockly is upgraded.

mo4islona commented 4 years ago

Thanks! It works fine.