search

moaazsidat / react-native-qrcode-scanner

A QR code scanner component for React Native.
MIT License
2.04k stars 517 forks source link

Fix the release ci process #363

Closed robwalkerco closed 2 years ago

robwalkerco commented 2 years ago

The previous three commits have not been deployed to npm, and this seems to be due to the deploy GitHub action failing on the semantic-release step (https://github.com/moaazsidat/react-native-qrcode-scanner/runs/4049234410?check_suite_focus=true)

This PR changes the required node version to 14, which should fix the issue that semantic-release is failing on ([semantic-release]: node version >=14.17 is required. Found v12.22.7.

I haven't been able to test the deploy process using node 14, so I'm not sure if there are any new issues created by this node version change.

I'm hopeful that it will allow the previous commits to be deployed to npm though 🤞

robwalkerco commented 2 years ago

@moaazsidat I would add you as a reviewer, but don't seem to be able to add any to this PR for some reason.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.5.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: