search

moacode / craft-fab-permissions

Restrict access to fields and tabs for particular user groups across your Craft elements.
Other
16 stars 9 forks source link

Globals Section Bug #14

Closed masonry47 closed 4 years ago

masonry47 commented 4 years ago

Hi there!

Since installing the plugin, we are having issues with the "Globals" section.

When clicking on "Globals", we get

"Trying to get property of non-object"

We are on:

Craft 3.3.19 Plugin Version: 1.2.3

All goes back to normal when disabling the plugin.

Thanks for your help!

moacode commented 4 years ago

Hey @masonry47, I'll have a look at this one for you tonight!

masonry47 commented 4 years ago

Thanks!

On Tue, Feb 18, 2020 at 2:04 PM Josh Smith notifications@github.com wrote:

Hey @masonry47 https://github.com/masonry47, I'll have a look at this one for you tonight!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thejoshsmith/craft-fab-permissions/issues/14?email_source=notifications&email_token=ALPGTX7K7S7DQX4KZMHRAKTRDQ5MVA5CNFSM4KXHJ422YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMEHZVI#issuecomment-587758805, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPGTX6CYN3CEPARMKWMGBTRDQ5MVANCNFSM4KXHJ42Q .

masonry47 commented 4 years ago

@thejoshsmith

Hi there, were you ever able to take a look at this issue? Thanks!

moacode commented 4 years ago

Hi @masonry47, sorry I was bit under the weather last week. I've just tried to replicate on my local dev site and I'm having trouble reproducing the error.

Could you please send me a screenshot, web.log or database to me@joshsmith.dev and I'll investigate further.

Cheers!

moacode commented 4 years ago

Closing due to inactivity.

masonry47 commented 4 years ago

Hey Josh

Apologies, we do still have interest in using the plugin and actually just today investigating as we have updated to most current version of Craft along with your plugin, and do get the same error. remind me again what to provide we will do it. Thanks!

moacode commented 4 years ago

No worries at all @masonry47! I was just tidying up the issues 😄. If you could please send me a copy of your database and composer.json/composer.lock files I should be able to replicate the issue you're seeing.

moacode commented 4 years ago

@masonry47 now marking as resolved 😄

Issue was identified as:

It had to do with the fact that the Translations plugin, created its own version of "Drafts" for Globals, since Craft natively does not have "Drafts" for globals. Which makes sense, if the client sends a Global content entry for translation, when it comes back the client needs to review the content before making it live, hence the Translations plugin made a "draft" for globals and I think that is where the conflict was. I think Acclaro updated how they handle that now with the latest version of Craft, So I think it is a non issue now.