search

moagrius / MapView

(Deprecated, prefer https://github.com/moagrius/TileView) Android widget roughly described as a hybrid between com.google.android.maps.MapView and iOS's CATiledLayer
http://moagrius.github.com/MapView/documentation
69 stars 35 forks source link

Create a jar with all dependencies #29

Closed mohlendo closed 11 years ago

mohlendo commented 11 years ago

Adds the maven assembly plugin in order to create a jar that contains all the dependencies, but excluding the android ones.

moagrius commented 11 years ago

thank you!

Shusshu commented 11 years ago

why do you need an assembly plugin? Why using old libs - just use https://github.com/mosabua/maven-android-sdk-deployer

moagrius commented 11 years ago

as a non-maven user i have no idea what's going on here. when this is decided please LMK what the resolution is (roll back, new merge, nothing...?)

Shusshu commented 11 years ago

I don't think a rollback is necessary, if the guy wants a uber jar then he will need the assembly plugin but I certainly won't be using it but it can stay.

My problem is more with the dependencies as it is now using old ones and that shouldn't be the case.

Let me explain. Maven has a central repository (search.maven.org) and normally google is supposed to upload it's product into that repository but they are not doing it currently. The android4maven group of volunteers did it for google in the past but they didn't add the latest sdk's and extra's.

Luckily for us Android Maven developers there is an alternative by using Android Maven SDK Deployer which can also be used in combination with a "company" repository.

moagrius commented 11 years ago

ok, thanks - just post back if anything's required of me.

i appreciate your help.

Shusshu commented 11 years ago

Yes, first I want a reply from the committer and then we'll do the changes

Benoit Billington

On Fri, Mar 22, 2013 at 7:13 PM, moagrius notifications@github.com wrote:

ok, thanks - just post back if anything's required of me.

i appreciate your help.

— Reply to this email directly or view it on GitHubhttps://github.com/moagrius/MapView/pull/29#issuecomment-15312779 .

mohlendo commented 11 years ago

Since the downloadable jar also includes the disklrucache stuff, I thought it would be a good idea to create that with maven. I don't use maven in my project but wanted to use the latest code and so I thought it would be nice to create the uber-jar with maven.

I thought that the dependencies I used, are the newest ones - well, they are the newest on maven central - but actually they are quite old.

Shusshu commented 11 years ago

The downloadable jar is for non maven users. For maven users this is not necessary.

I strongly suggest you to take a look at Maven Android SDK Deployer.

I will submit a new pull request to put other dependencies using the latest version of google extra & sdk

Benoit Billington

On Fri, Mar 22, 2013 at 7:53 PM, Manuel Ohlendorf notifications@github.comwrote:

Since the downloadable jar also includes the disklrucache stuff, I thought it would be a good idea to create that with maven.

I thought that the dependencies I used, are the newest ones - well, they are the newest on maven central.

— Reply to this email directly or view it on GitHubhttps://github.com/moagrius/MapView/pull/29#issuecomment-15315033 .