search

moagrius / TileView

TileView is a subclass of android.view.ViewGroup that asynchronously displays, pans and zooms tile-based images. Plugins are available for features like markers, hotspots, and path drawing.
MIT License
1.46k stars 337 forks source link

ZoomPanLayout.smoothScaleTo() is not animating #32

Closed corsc closed 11 years ago

corsc commented 11 years ago

The ZoomPanLayout.smoothScaleTo() wasn't animating, only moving.
These changes should address that.

Change details: -Changed System.currentTimeMillis() to SystemClock.elapsedRealtime() for better animation reliability around clock changes. (This is not necessary and you can ignore if you prefer the previous way) -Added call to ZoomPanLayout.saveHistoricalScale() in TweenListener this should fix a bug that was preventing scale based animations

Because I based the changes on my earlier PR, I cant seem to be able to PR this to you yet. Please refer to this: https://github.com/Sage42/TileView/commit/b7715440e228a6b4a634586a89fde36d164ef51e

moagrius commented 11 years ago

will do, thanks... fwiw i think you can create a new fork off the main repo, make changes to that fork, and pr that one (at least, i'd have to think that'd work)... not necessary in this case, i'll make the updates manually early next week. thanks again

corsc commented 11 years ago

yeah, if u want the changes faster I can remake them of the master otherwise if you accept the other change then I can PR this in after that is accepted. Whatever is best for you.

moagrius commented 11 years ago

i'll do this update (the smoothScaleTo) manually, early next week, then review the other bigger one (i'm leaning toward asking you to modify the tile selection update to use an interface-based approach, like you see with the BitmapDecoder interface), but we can discuss it in that thread next week as well). gonna shut down for the night, will check back in tomorrow - thanks again for contributing.

moagrius commented 11 years ago

this has been fixed in the latest commit and release

(i didn't change the clock but just because i'm short on time - i may in the future, or you can do so and PR if you wish)

thanks again @corsc