search

moagrius / TileView

TileView is a subclass of android.view.ViewGroup that asynchronously displays, pans and zooms tile-based images. Plugins are available for features like markers, hotspots, and path drawing.
MIT License
1.46k stars 337 forks source link

Borders and markers improvement #466

Closed Derpalus closed 6 years ago

Derpalus commented 6 years ago

In relation to issue #460 and #463.

I have never done any pull requests on GitHub before so I don't know if any more info is required.

moagrius commented 6 years ago

At first glance this looks pretty good - there's a couple nits about naming and method signature but I think it'll probably be very minor changes. I need to run it a couple times and am slammed right now, let's shoot for mid week for a review.

Thanks for this.

moagrius commented 6 years ago

i haven't forgotten about this - just no time yet - sorry

moagrius commented 6 years ago

aiming for this weekend to merge

Derpalus commented 6 years ago

And there was much rejoicing! :D

moagrius commented 6 years ago

Ha - i believe 2.2.9 is now on jcenter - testing out some demos to make sure there weren't any unexpected side effects

moagrius commented 6 years ago

after a quick run through, everything looks good (as expected). feel free to add samples to the demo, instructions to the readme, or a page to the wiki, but don't feel obligated.

thanks for contributing!