search

moagrius / TileView

TileView is a subclass of android.view.ViewGroup that asynchronously displays, pans and zooms tile-based images. Plugins are available for features like markers, hotspots, and path drawing.
MIT License
1.46k stars 335 forks source link

Issues scaling past 1f #518

Closed moagrius closed 5 years ago

moagrius commented 5 years ago

There are several issues when scaling larger than 100%. Bounds are broken, tiles are forced into unnecessary recomputation and render, and more.

This is being actively worked on as this issue was created.

moagrius commented 5 years ago

working on this, seems to be the last major bug (i have the other bugs fixed in my working branch, wanted to keep them in the same codebase as I work on this). interestingly, it works perfectly in ScalingScrollView, but is simpler because it's managing all size related queries as scaled, while in TileView we don't actually do that (e.g., we wouldn't want to scale markers or paths, etc).

@peterLaurence if you get a chance and have the inclination, I'd welcome any input on this bug. That said, I am going to keep working on it until it's fixed, so if you don't have the bandwidth or just don't feel like it, it's totally no problem - I already ask too much of you.

moagrius commented 5 years ago

@peterLaurence nevermind, i found it. so dumb - missing setClipChildren(false) on the container... i'll clean this up, test it thoroughly myself, then push the the bug fix branch and open a PR. Tonight or tomorrow, unless other problems arise.

moagrius commented 5 years ago

Corrected in https://github.com/moagrius/TileView/pull/520