search

moagrius / TileView

TileView is a subclass of android.view.ViewGroup that asynchronously displays, pans and zooms tile-based images. Plugins are available for features like markers, hotspots, and path drawing.
MIT License
1.46k stars 337 forks source link

White text on white background in Advanved Tile Demo #532

Open tva-TIS opened 5 years ago

tva-TIS commented 5 years ago

Minor colouring issue within TileViewDemoAdvanced in Version 4:

Problem InfoWindow that's displayed when the markers are clicked on has invisible (white on white) text.

Reason

  1. Version 4 hasn't set AppTheme set in Android Manifest (in difference to previous version)
  2. Version 4 has set a white background to the infoWindow (Version 3 has got a grey one)

Solution

  1. Set Background Color back to something dark (TileViewDemoAdvanced.java:getInfoView)
  2. Set Text Color to Something dark (TileViewDemoAdvanced.java:getInfoView)

At first i thought setting AppTheme in the Manifest would solve the issue too, but AppTheme inherits from an Theme that's not compatible with AppCompat. And if that's changed (for example to @style/Theme.AppCompat.NoActionBar that somehow doesn't solve the issue either (maybe AppCompat Themes don't override colors/set text color to white). I've tested the other two solutions, they do the trick.

moagrius commented 5 years ago

Thanks, will fix next time I'm on the project.