search

moagrius / TileView

TileView is a subclass of android.view.ViewGroup that asynchronously displays, pans and zooms tile-based images. Plugins are available for features like markers, hotspots, and path drawing.
MIT License
1.46k stars 337 forks source link

Why don't you use the ScrollerCompat? #6

Closed mohlendo closed 11 years ago

mohlendo commented 11 years ago

The Android Support Library, revision 13 introduced a new ScrollerCompat that provides all the functionality that the TileView needs. Is there a reason why you don't use that? Maybe I am missing something.

moagrius commented 11 years ago

The Scroller class used by TileView is actually the 4.0API's version, retrofitted to work with the older API's I'm targetting (2.2 and up): https://github.com/moagrius/TileView/blob/master/src/com/qozix/widgets/Scroller.java

It doesn't look like there's anything in ScrollerCompat that doesn't exist in the hacked Scroller class being used, but it might be more future proof - I'll take a look and see if it'd be an easy swap out, and wouldn't have any API conflicts.

moagrius commented 11 years ago

... or I can merge if you've already got this implemented in a fork and there are no conflicts.

mohlendo commented 11 years ago

I have created a pull request: https://github.com/moagrius/TileView/pull/7