search

moai / moai-dev

This is the development repo of Moai SDK.
http://getmoai.com
944 stars 313 forks source link

Add capability to track a transform's position with MOAICameraFitter2D. #1177

Closed monomon closed 8 years ago

monomon commented 8 years ago

Add an example too

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

moai-sdk commented 8 years ago

Can one of the admins verify this patch? Type 'test' in a comment to start test.

ConghuZhao commented 8 years ago

Test

seclorum commented 8 years ago

I've tested it locally, looks good to me. @halfnelson, what say you?

monomon commented 8 years ago

I still have to provide a better example, because this one doesn't make it visually apparent what is happening.

ConghuZhao commented 8 years ago

hey @seclorum the build is tested on ci jenkins, and moai-sdk is the account for it. so any pull request made the moai-sdk will prompt admin which are patrick @seclorum @halfnelson and @makotok for approve, all you need to do is reply "test" on the pull request, this will kick off the build job on our build server. the result will be post on pull request like this

seclorum commented 8 years ago

@ConghuZhao Roger that! I'm happy to see the CI build it, but I'm also willing to manually test/inspect these kinds of things before the PR gets merged .. this PR gets a thumbs-up from me on that angle, anyway.

seclorum commented 8 years ago

@monomon re:

I still have to provide a better example, because this one doesn't make it visually apparent what is happening.

I think with DEBUG_LINES turned on, things are obvious no?

MOAIDebugLines.setStyle(MOAIDebugLines.PARTITION_CELLS, 2, 0, 0, 1, 1)
MOAIDebugLines.setStyle(MOAIDebugLines.PARTITION_PADDED_CELLS, 1, 0, 1, 0, 1)
MOAIDebugLines.setStyle(MOAIDebugLines.PROP_WORLD_BOUNDS, 2, 1, 0, 0, 1)
MOAIDebugLines.setStyle(MOAIDebugLines.PROP_MODEL_BOUNDS, 5, 1, 0.6, 0, 1)
--MOAIDebugLines.setStyle(MOAIDebugLines.TOTAL_STYLES, 2, 1, 1, 0, 1)
monomon commented 8 years ago

Thank you, it does become clearer. Committed the updated example.

halfnelson commented 8 years ago

Nice one, Thanks for the contribution