search

moallemi / Film-Time

A Movie and TV shows tracking app illustrating Android development best practices with Jetpack Compose
MIT License
95 stars 15 forks source link

[FR]: Movies by Genres #100

Closed hadi-norouzi closed 2 months ago

hadi-norouzi commented 3 months ago

Is there an existing issue for this?

Related app

All - Android

Describe the problem

I need to click on genre in movie/show detail page and get list of movies/shows by that genre.

Describe the solution

No response

Additional context

No response

Code of Conduct

moallemi commented 3 months ago

You can work on this. Please check if we can reuse the video-thumbnail-grid module.

hadi-norouzi commented 3 months ago

video-thumbnail-grid takes two params, VideoType and VideoListType. Do you think it's ok to add another param for genre? or add another module only for genre grid?

moallemi commented 3 months ago

No. Just make this VideoThumbnailGridScreen (Line: 55) public and use it with your new view model in a new module:

@Composable
private fun VideoThumbnailGridScreen(
  state: VideoThumbnailGridUiState,
  pagedList: LazyPagingItems<VideoThumbnail>,
  onMovieClick: (tmdbId: Int) -> Unit,
  onShowClick: (tmdbId: Int) -> Unit,
  onBack: () -> Unit,
)