Beautify show detail page

[u3frajaeian]

Add two sections in the show detail page to represent similar, casts

[moallemi]

Dear @u3frajaeian, Thanks for your contribution. would you please update your branch with dev?

[moallemi]

And we do do not need play button or navigating to player from shows detail page. You can remove it. (Episodes should have play button not Show details)

[u3frajaeian]

Dear @u3frajaeian, Thanks for your contribution. would you please update your branch with dev?

Hi it's already updated

[u3frajaeian]

And we do do not need play button or navigating to player from shows detail page. You can remove it. (Episodes should have play button not Show details)

Hi, I think we must have an intro for the series, and this button should play something like a trailer or intro.

[moallemi]

Dear @u3frajaeian, Thanks for your contribution. would you please update your branch with dev?

Hi it's already updated

But the conflicts are not resolved yet.

Hi, I think we must have an intro for the series, and this button should play something like a trailer or intro.

Yes, we could consider having a "Trailers" button, But Using a play icon without accompanying text for different functionalities can be confusing. The button's label should clearly indicate its purpose so that users can easily understand its function. Also that is outside the scope of this issue. and if we want to add that button, it should navigate to another screen since Shows and movies usually have more than one trailers.

[u3frajaeian]

Dear @u3frajaeian, Thanks for your contribution. would you please update your branch with dev?

Hi it's already updated

But the conflicts are not resolved yet.

Hi, I think we must have an intro for the series, and this button should play something like a trailer or intro.

Yes, we could consider having a "Trailers" button, But Using a play icon without accompanying text for different functionalities can be confusing. The button's label should clearly indicate its purpose so that users can easily understand its function. Also that is outside the scope of this issue. and if we want to add that button, it should navigate to another screen since Shows and movies usually have more than one trailers.

Dear Reza, It appears that everything is already updated. After fetching the updated branches and attempting to merge remote/dev with my branch, I received a message stating: "Already up to date."

[u3frajaeian]

Dear @u3frajaeian, Thanks for your contribution. would you please update your branch with dev?

Hi it's already updated

But the conflicts are not resolved yet.

Hi, I think we must have an intro for the series, and this button should play something like a trailer or intro.

Yes, we could consider having a "Trailers" button, But Using a play icon without accompanying text for different functionalities can be confusing. The button's label should clearly indicate its purpose so that users can easily understand its function. Also that is outside the scope of this issue. and if we want to add that button, it should navigate to another screen since Shows and movies usually have more than one trailers.

Yes, you are right. I completely misunderstood the function of this button. I assumed the play button was responsible for showing trailers because Filmtime isn't a streaming application. However, based on your description, I will remove it.

[moallemi]

Dear Reza, It appears that everything is already updated. After fetching the updated branches and attempting to merge remote/dev with my branch, I received a message stating: "Already up to date."

Hi @u3frajaeian, The message indicates that the branch is updated because it is being compared with your dev branch on your repository. When you create a PR against the original repository you forked from, you must sync your branch with the latest changes before creating the PR. Currently, there are many conflicts, as shown in the screenshot I sent you earlier.

To have a better overview of what I am telling, take a look at this screenshot:

Solution

I suggest you follow one of the options from this document and sync your repo.