moaxaca / async-redis

First class async & promise support for redis.
Other
168 stars 21 forks source link

Decorate Multi objects returned by client #15

Closed jd20 closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 40


Totals Coverage Status
Change from base Build 35: 0.0%
Covered Lines: 35
Relevant Lines: 35

💛 - Coveralls
moaxaca commented 5 years ago

I will test this later this week.

jd20 commented 5 years ago

One issue I've noticed, if you have code that is calling multi() a lot, the performance overhead of decorating the Multi object every time can be significant. I'm thinking we might want a smarter way to do the decoration only once.

moaxaca commented 5 years ago

@jd20 Yea I've been considering overhauling parts of the library. Making more of a proxy class over attempting to decorate it.

moaxaca commented 5 years ago

Could you clean up the linting errors caught by CI?

jd20 commented 5 years ago

@moaxaca Yes, a proxy class should improve performance greatly. I pushed a commit for the linter errors.

moaxaca commented 5 years ago

I will look into a proxy implementation with an identical interface.

Thanks for contributing.