search

moayadnajd / nativescript-filter-select

A NativeScript plugin to provide an listview widget to select AND filter items
http://codeobia.com
Other
37 stars 19 forks source link

Render label or drop hides all elements underneath Filter Select #51

Open delanick opened 6 years ago

delanick commented 6 years ago

Hi @moayadnajd

This is an awesome plugin, thank you!! :) Been looking for this for a long time!

One issue: When I render tags, the page content underneath the Filter Select displays normal, but when rendering label or drop, all page content underneath it disappears. Please look into this as I would like to use label render, but still have stuff under that on my page.

moayadnajd commented 5 years ago

@delanick can you make example https://play.nativescript.org so i can help you faster

delanick commented 5 years ago

@moayadnajd funny enough, now it works perfectly and I can't reproduce the problem, even though it initially happened on Playground as well as on my app. I will try a rebuild of the app with the other properties and see if it happens again and then will copy that code for you.

I have however just come across another problem I wanted to log too. It also happens on my app, as well as the Playground app I just created. Once I've selected a value and the is now replaced by the value, I can't simply click on it and select another value. The modal appears and the list items shows a click, but the modal doesn't disappear and the new item displays. I actually have to close the modal and then open it again and select the new value - you can't choose two different values twice in succession. Can you look at that?

My Playground link: https://play.nativescript.org/?template=play-js&id=MwXXn5&v=5

moayadnajd commented 5 years ago

@delanick that's a disaster every time NativeScript updated i have to make a lot of changes in the code what version of NativeScript you have ? there is no fast way to fix that and i am busy now maybe you can check older versions of NativeScript!

delanick commented 5 years ago

@moayadnajd Thanks for the feedback. I'll see what the users say and change it to a normal list view if needed as the content isn't so much yet that the filter is needed, so perhaps once you've had time to work on it I would be able to implement it once our content has grown enough to need it.

This may be asking a lot, but once you do have time, is there any way you can change it to not include the UI (just the modal page) so we build our own UI with a normal search box and list view, but that the api allows search and filter features as current? That way you shouldn't ever have to update the plugin after {N} updates. Just a thought :) May save you headaches. :)

moayadnajd commented 5 years ago

@delanick actually I am trying to do something like you ask but i couldn't #5 thats need a lot of time or maybe a good nativeScript experiance

delanick commented 5 years ago

@moayadnajd Awesome! Would love to see what you come up with :)