Closed itsagam closed 5 years ago
Hi @itsagam Thsnk you for reporting!
Hmm, It does not work correctly on game view in editor, right?
Indeed, I saw there were previous issues with Overlay but they were closed. Not sure what’s hapenning. Thank you for making your work available though.
Okay, I'll fix it as soon as possible. Thank you again!
Please try v0.7.2
Okay, I tested it. It works in Screen-Space Overlay mode now, but the code changes introduced a regression where it doesn't work as intended in Screen-Space Camera and World Space. The masked image is offset by viewing position (see screenshots).
This is just to report. I bought an package from Asset Store that got the job done. Thanks!
Thank you for testing. :) For the time being, we have discontinued the v0.7.2 release. I will continue to fix.
Hi @itsagam Can you test this? fixed.unitypackage.zip
If there is no bug, I will release v0.7.2. :)
Sure, sure. Okay, so, the asset works now in all three modes (Screen-Space Overlay, Screen-Space Camera, World Space), but while testing it thoroughly, I encountered two more bugs:
1) If you maximize Game View (either with "Game -> Right-click -> Maximize" or "Maximize on Play"), the masked images all disappear.
2) Intermittently, get "Attempting to ReadPixels outside of RenderTexture bounds! Reading .... from ...." errors.
I had the package from v0.7.1, so I installed it again to see whether these were a regression, but they happen there as well and seem to be unrelated to the changes you made. I wish I could help you diagnose any of it, but shader programming is not my forte. Do let me know, however, if you ever need some help with editor scripting side of things.
Best.
Reading the exception now, maybe it is an off-by-one error? Trying to read pixel 289 from size 288? Just a thought, I'm a noob with shaders.
Many thanks! And, 3. the masked image disappears when the game view is resized.
Actually, the bugs are independent. I created new issues for the bugs and fixed them!
Please try this fixed_2.unitypackage.zip
Works good.
Thank you for your cooperation! :+1: I'll release it.
Doesn't work in "Screen Space - Overlay" (shows correctly in the Editor but does not work in-game).
Steps to reproduce the behavior:
Scroll up and notice.