mob-sakai / SoftMaskForUGUI

Enhance Unity UI (uGUI) with advanced soft-masking features to create more visually appealing effects!
https://github.com/mob-sakai/SoftMaskForUGUI
MIT License
1.97k stars 261 forks source link

[critical] Bug build IL2CPP #84

Closed stalker1hunt closed 4 years ago

stalker1hunt commented 4 years ago

Describe the bug I want build in IL2CPP and have bug. But i fixed his like: Old

        protected override void OnValidate()
        {
            graphic.SetMaterialDirty();
            OnTransformParentChanged();
            base.OnValidate();
            _hasStencilStateChanged = false;
        }

new

        protected void OnValidate()
        {
            graphic.SetMaterialDirty();
            OnTransformParentChanged();
            _hasStencilStateChanged = false;
        }

With a new code bug has been solved.

To Reproduce Steps to reproduce the behavior: 1) Build

Expected behavior Library\PackageCache\com.coffee.softmask-for-ugui@f5f5b7e3413b16a9f9ba8e27fcf7f22a0f82adac\Scripts\SoftMask.cs(417,27): error CS0115: 'SoftMask.OnValidate()': no suitable method found to override

Screenshots http://prntscr.com/scg6mz

Environment (please complete the following information):

maskedmouse commented 4 years ago

OnValidate() in Mask is inside a #if UNITY_EDITOR. When you build for Android the base.OnValidate method won't exist resulting into a build error.

My guess is, that you forgot to uncomment line 387 & 424 in SoftMask.cs

mob-sakai commented 4 years ago

@stalker1hunt @maskedmouse Thank you for reporting. I'll fix it ASAP.

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 0.10.0-preview.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: