mob-sakai / UIEffect

UIEffect is an effect component for uGUI element in Unity. Let's decorate your UI with effects!
https://github.com/mob-sakai/UIEffect
MIT License
5.57k stars 770 forks source link

Unity 2020 support #224

Open buihuuloc opened 3 years ago

buihuuloc commented 3 years ago

Hi @mob-sakai

Could you see If the package supports Unity 2020?

Currently, we have some problem with Unity 2020

mob-sakai commented 3 years ago

@buihuuloc OK, I will check it later.

elopezga commented 3 years ago

If this helps, I was able to get version 3.2.0 to work on Unity 2020.1.2f1. I previously attempted to get the latest version, 4.0.0 preview 9 at the time of this writing, via package manager. I kept gettingCan't add script behaviour ScriptName. The script class can't be abstract! error message when adding any of the UI Effects. I installed v3.2.0 via Unity package and it worked for me. So my guess is something changed between v3.2.0 and v4.0.0p9 that causes that error message to show or the installation doesn't work through Unity package manager. Would be interesting to see if v4.0.0p9 works via Unity package installation, but I don't see how the method of installation would be an issue.

mob-sakai commented 3 years ago

@elopezga Thank you for the information.

buihuuloc commented 3 years ago

Thanks @mob-sakai

drallcom3 commented 3 years ago

I get various errors with 2020.2 and 4.0.0 preview 9 (from package manager). The old downloadable 3.X version works fine and is as amazing as ever.

mob-sakai commented 3 years ago

@buihuuloc @elopezga @drallcom3 I have installed UI Effect in empty project and played Demo scene, but no errors...

I would like to know more about this issue.

drallcom3 commented 3 years ago

I tried again and now it seems to work. I only had to place some namespaces (I think you switched it at some point). In a fresh project it also works. 2020.2.0b5.

Btw, in 2020.2 you can directly add Git URLs in the package manager. No need to edit the manifest.

mob-sakai commented 3 years ago

Yes, the namespase has been changed in 4.0.0-preview.8. https://github.com/mob-sakai/UIEffect/commit/7f4190c8c6f294e90869767a96194ec5ac4ba57f https://github.com/mob-sakai/UIEffect/releases/tag/v4.0.0-preview.8

change change namespace (7f4190c)

BREAKING CHANGES If your code contained the UIEffect API, it would fail to compile. Please change the namespace from Coffee.UIExtensions to Coffee.UIEffects.

I concerned that some of the class names were conflicted with other packages. For example, GraphicConnector class:

drallcom3 commented 3 years ago

Yes, I missed that. All fine now. No bugs from upgrading to v4.

mob-sakai commented 3 years ago

@drallcom3 :+1:

xiangsoft commented 2 years ago

Hello I still have same problem with version 4.0.0-p9, Can't add script behaviour ScriptName. The script class can't be abstract! Platform:Windows Version:2020.3.21f1c1