search

mob-sakai / UpmGitExtension

This package extends the UI of Unity Package Manager (UPM) for the packages installed from git repository.
MIT License
773 stars 80 forks source link

Not functioning on 2020.1.0 #105

Closed AndrewCarvalho closed 3 years ago

AndrewCarvalho commented 3 years ago

Description The package does not function on 2020.1.0 (and possibly 2019.X.0)

To Reproduce

Expected behavior The package should not throw errors

Environment

Additional context I've tracked this down to the InternalBridge class which overrides the provided unity preprocessor macros for checking the version. There are explicit checks for multiple versions of unity but the UNITY_2020_1_0 revision is missing from the list.

I'm unsure as to why the define needs to be overridden (I haven't done thorough testing with old version) but removing the override od UNITY_2020_1_5_OR_NEWER solves the issue.

AndrewCarvalho commented 3 years ago

I added the UNITY_2020_1_0 to the list of version not included in UNITY_2020_1_5_OR_NEWER as I am not sure how removing the override may effect other version of Unity and this seemed safer.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.3.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: