search

mob-sakai / UpmGitExtension

This package extends the UI of Unity Package Manager (UPM) for the packages installed from git repository.
MIT License
773 stars 80 forks source link

sub dir not working #108

Closed hannesdelbeke closed 2 years ago

hannesdelbeke commented 3 years ago

Describe the bug Sub directory not working when trying to use through tool Sub directory working when using manually by appending "?path=/SUB_DIRECTORY_NAME" to the giturl in the manifest

To Reproduce Steps to reproduce the behavior:

  1. Go to package manager with UPM git extension installed
  2. Click on the red icon top left to add new git package
  3. Add repo URL and subfolder
  4. version in subfolder doesnt show up

Expected behavior version to correctly show up for packages in a subfolder

Screenshots /

Environment (please complete the following information):

Additional context tested with a fork of this repo version updates to the json show up correctly in unity when pushed in root folder when moving whole project to a subfolder any version updates in that subfolder do not show

when looking at the stdout that is printed by the console.log in get-available-versions.js we see

redacted output from unity the package added manually in the manifest using /path correctly shows subfolder subDir is correctly passed to get-available-versions.js manual.txt

when trying to add a package from git through this extension using subfolder subDir is not passed to get-available-versions.js gitextension.txt

hannesdelbeke commented 3 years ago

fixed formatting in original post and uploaded logs as txt files

hannesdelbeke commented 3 years ago

when manually adding to the manifest, unity finds the json from the package in the subdirectory 1.3.6 is latest commit and in the subdir. note that the dropdown with any previous versions is gone image

image

hannesdelbeke commented 3 years ago

but when trying to load the package using this extension, only the versions in the rootfolder show up it seems to ignore what i put in the sub-directory field and always show the same versions image

1.3.5 is a test version i added in the root folder this shows up correctly

1.3.6 is a test version i added in the sub directory this does not show up

mob-sakai commented 3 years ago

@hannesdelbeke Thank you for your reporting!