search

mob-sakai / UpmGitExtension

This package extends the UI of Unity Package Manager (UPM) for the packages installed from git repository.
MIT License
773 stars 80 forks source link

Cannot implicitly convert type 'UnityEditor.PackageManager.UI.IPageManager' - OpenUPM install - 2020.1 #93

Closed MostHated closed 4 years ago

MostHated commented 4 years ago

Hey there, This was my first attempt as installing this plugin, but I ran into an issue it seems. I used OpenUPM 1.8.0 via "openupm add com.coffee.upm-git-extension" but after compilation, I received a few errors:

[CompilerError] Cannot implicitly convert type 'UnityEditor.PackageManager.UI.IPageManager' to 'UnityEditor.PackageManager.UI.PageManager'
Compiler Error at Library\PackageCache\com.coffee.upm-git-extension@1.3.0\Editor\Coffee.UpmGitExtension\InternalBridge.cs:137 column 13
135:               ServicesContainer.instance.Resolve<PageManager>();
136:   #else
-->137:               PageManager.instance;
138:   #26 f
[CompilerError] 'PageManager' does not contain a definition for 'onListRebuild' and no accessible extension method 'onListRebuild' accepting a first argument of type 'PageManager' could be found (are you missing a using directive or an assembly reference?)
Compiler Error at Library\PackageCache\com.coffee.upm-git-extension@1.3.0\Editor\Coffee.UpmGitExtension\InternalBridge.cs:143 column 33
141:   {
142:       Action<IPage> act = _ => action();
-->143:       PageManagerInstance.onListRebuild -= act;
144:       PageManagerInstance.onListRebuild += act;
145:   }
[CompilerError] 'PageManager' does not contain a definition for 'GetCurrentPage' and no accessible extension method 'GetCurrentPage' accepting a first argument of type 'PageManager' could be found (are you missing a using directive or an assembly reference?)
Compiler Error at Library\PackageCache\com.coffee.upm-git-extension@1.3.0\Editor\Coffee.UpmGitExtension\InternalBridge.cs:192 column 34
190:   {
191:       var empty = Enumerable.Empty<IPackage>();
-->192:       (PageManagerInstance.GetCurrentPage()).OnPackagesChanged(empty, empty, empty, GetGitPackages());
193:   }

Environment (please complete the following information):

mob-sakai commented 4 years ago

@MostHated Thank you for your reporting!

MostHated commented 4 years ago

Of course, not a problem. If you need any additional information that might help, don't hesitate to let me know.

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 1.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

MostHated commented 4 years ago

Great news, thanks. I will give this a try again. 👍