moberwasserlechner / vaadin-chartjs

Vaadin 8 wrapper for ChartJS v2.x library
MIT License
56 stars 35 forks source link

Update data after component already initialised #11

Closed moberwasserlechner closed 8 years ago

moberwasserlechner commented 8 years ago

http://stackoverflow.com/questions/21137768/passing-a-object-from-server-to-client-with-vaadin https://vaadin.com/wiki/-/wiki/Main/Integrating%20a%20JavaScript%20library%20as%20an%20extension

gokhanoner commented 8 years ago

Hi Michael, if it's ok, I want to contribute on this feature and some others also ?

moberwasserlechner commented 8 years ago

Hi Gökhan,

Your contribution would be very welcome. Please create PRs for that. (see https://github.com/moberwasserlechner/vaadin-chartjs#contribute)

If you need help please let me know.

Cheers, Michael

gokhanoner commented 8 years ago

Michael,

I'm gettin error while importing it:

Could not get unknown property 'BINTRAY_USER'

I think it's defined on your side but I dont have this prop. set. ??

There is a similar issue & solution: https://github.com/openmhealth/schemas/issues/3

moberwasserlechner commented 8 years ago

Actual I ran into the same issue myself while setting up travisci for another project.

I'll have it fixed here later this evening.

gokhanoner commented 8 years ago

OK, I temp. fix it with adding those properties to gradle.prop files. But gave another problem.

I made some changes & also update the demo. But I cannot compile demo. Is there something missing/commented on demo to prevent it?

ps: I developed with maven so little experience with gradle, so maybe I couldn't figure it out. sorry for that.

moberwasserlechner commented 8 years ago

My setup for developing vaadin plugins right now is:

Import to Eclipse

I've created #25 to address your problems and make contribution easier. I think it would be best you postpone your work until I've resolved this issue.

Could you please give me a few insights in your development environment?

gokhanoner commented 8 years ago

Hi, I'm using

Vaadin Gradle plugin seem to work with IDE, but If demo don't use any addons, which is not, you dont need that addon at all. We can use just gradle as a build tool. If It's OK, I can look at that.

Example project setups: (gradle configs)

https://github.com/spring-guides/gs-crud-with-vaadin https://github.com/christoph-frick/springboot-groovy-vaadin-starter

Please let me know so I can go step by step.

Also, do demo need to be a war application, is jar ok ? ( For deploying demo server ) It would be much more simpler this way.

Last thing, is there a specific reason for you to build with Gradle ? I believe maven would be much more easier I believe.

Also, can you move demo to a new repo ? That will also make the setup simple ..

gokhanoner commented 8 years ago

UPDATE:

I've succesfully completed this issue. The changes where minimal.

How I did test:

moberwasserlechner commented 8 years ago

Hi,

great to hear.

Try to integrate your new view classes to the demo, so I get the idea (I must not be complete as I could fix any issues after merging) or add the example code as a comment.

After that please create a pull request so I can review the changes and merge it.

Cheers and gn8, Michael

gokhanoner commented 8 years ago

Michael,

I also manage to run demo on Idea, using your current structure with spring-boot. Do you want me to update those changes also ?

moberwasserlechner commented 8 years ago

Not directly.

Please move those changes to another branch and create another pull request.

gokhanoner commented 8 years ago

OK, I just created a pull request for first part, refreshing data, also added a view as an example.

moberwasserlechner commented 8 years ago

Thanks.