search

mobfishgmbh / Cardboard-VR-Unity-SDK

Apache License 2.0
56 stars 11 forks source link

Unity XR-Plugin Support #72

Open jnroesch opened 4 years ago

jnroesch commented 4 years ago

Hey there, I wanted to ask if you plan on supporting the new Unity XR Plugin Framework added in Unity 2019.3.

As far as I know the current implementation basically moves all rendering into the frontend/UI and does not rely on any VR functionality at all. Unity basically doesn't even recognize it is in VR mode. To my understanding this is also the reason for the performance issues stated in other tickets.

This seems to be a risky approach as changes to the UI / PP system will also potentially break this VR implementation.

The "official" cardboard unity wrapper or whatever google calls it uses the new unity system but lacks a lot of other features.

I would like to use the mobfish sdk in my project but unfortunately the performance is a breaker for me. Therefore I would love to hear your thoughts on how you want to proceed with the development. Do you plan to stick with the UI driven rendering or are you going to support the more natively integrated Unity XR package?

Cheers

cdytoby commented 4 years ago

@jnroesch Thanks for the message.

This project is currently not in active development, if there are bug report I'll look into it, but further feature development will not be done, at least for now. Unity XR package is exactly what google is doing right now, and there is no plan on supporting it on our side.

The purpose this project, is to offer a possibility to get Cardboard working with basic requirement like OpenGL ES 3.0 and Metal, get over with the iOS app submission issue, and some important features (for us) that's not there in original Google VR package. These requirements are met and due to multiple reasons, we're unable to deliver a further plan for the development. And I'm very sorry about that.

About the implementation, the VR view part is not using any UI things, it's using the "OnPostRender" (I don't know if it belongs to post process) to create left and right eye images. The only UI here are the buttons that interact with users. It's also possible to create your own UI here, or add more features, it's really up to developers.

If you're interested in contributing to this project, feel free to create a fork and make your own change. It's totally fine to ditch the "PostProcess" and use other approches to create a VR view, or even use the Unity XR package. I'll be glad to merge it, or at least make it a branch here, if everything works as expected.