mobfox / MobFox-iOS-SDK

Apache License 2.0
15 stars 12 forks source link

GADMAdapterMobFox duplicated files #41

Closed vitorhugomagalhaes closed 7 years ago

vitorhugomagalhaes commented 7 years ago

Hi,

I'm trying to integrate MobFox Admob adapter but inside the project the files GADMAdapterMobFox.h/.m are duplicated inside the Adapters folder and also inside the Samples/AdMobAdapterSample/AdMobAdapterSample.

Since they are different which version is the correct one ?

BR,

nabriski commented 7 years ago

Hi,

Please use this folder: https://github.com/mobfox/MobFox-iOS-SDK/tree/master/Adapters/AdMob We will fix this duplication soon.

vitorhugomagalhaes commented 7 years ago

Hi,

Thanks.

Another error I'm getting when using the pod version is that MFEventsHandler.h is not exposed in the public headers.

Is the pod deprecated ?

BR,

vitorhugomagalhaes commented 7 years ago

As a side note, I decided to use the latest release from this repo.

The module could not be compiled becaused MobFoxAdTest.h is not added to MobFoxCore.h

I've added the missing import and it works.

Still, I'm not sure if the MobFoxAdTest.h is supposed to be there.

Could you please check this ?

Thanks,

shimisheetrit commented 7 years ago

Hi,

Have you integrated the SDK manually or using cocoa pods?

vitorhugomagalhaes commented 7 years ago

Hi,

I've tried using cocoapods but got the MFEventsHandler error.

Now I'm trying it manually but got the missing MobFoxAdTest import error.

Just trying to make this work :)

nabriski commented 7 years ago

ok, we're trying to reproduce and fix this. Will update this issue.

nabriski commented 7 years ago

Uploaded a fix and also updated cocoapods. Sorry, this is what we get for rushing things this week.